Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to declare IFindItemAttribute at any level #254

Closed
YevgeniyShunevych opened this issue Apr 23, 2019 · 0 comments

Comments

1 participant
@YevgeniyShunevych
Copy link
Member

commented Apr 23, 2019

Currently IFindItemAttributes such as FindItemByLabelAttribute and FindItemByValueAttribute can only be declared at property level. Add the ability to declare IFindItemAttribute at any level.

  • Update OptionList<T, TOwner> to get IFindItemAttribute dynamically from any metadata level.
  • Remove IItemsControl interface from OptionList<T, TOwner>. This interface should become obsolete.
  • Mark CheckBoxList<T, TOwner> and RadioButtonList<T, TOwner> with [FindItemByLabel] attribute.
  • Change AttributeUsage of FindItemByLabelAttribute and FindItemByValueAttribute to be [AttributeUsage(AttributeTargets.Property | AttributeTargets.Class | AttributeTargets.Interface | AttributeTargets.Assembly, AllowMultiple = true)].

@YevgeniyShunevych YevgeniyShunevych added this to the 1.1.0 milestone Apr 23, 2019

@YevgeniyShunevych YevgeniyShunevych self-assigned this Apr 23, 2019

YevgeniyShunevych added a commit that referenced this issue Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.