Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IUIComponentVerificationProviderExtensions.Exist method to throw AssertionException instead of NoSuchElementException #286

Closed
YevgeniyShunevych opened this issue Jun 12, 2019 · 0 comments

Comments

1 participant
@YevgeniyShunevych
Copy link
Member

commented Jun 12, 2019

Currently:

  • Component.Should.Exist() method throws NoSuchElementException.
  • Component.Should.Not.Exist() method throws NotMissingElementException.

Both should throw AssertionException (as all other verification methods do) with inner exception equal to the one of the above. So element exception details (that are useful) will not be removed but wrapped with AssertionException.

In the result error should look like:

Message: Atata.AssertionException : Invalid "Result" element presence.
Expected: should exist
  ----> OpenQA.Selenium.NoSuchElementException : Unable to locate visible element...

@YevgeniyShunevych YevgeniyShunevych added this to the 1.2.0 milestone Jun 12, 2019

@YevgeniyShunevych YevgeniyShunevych self-assigned this Jun 12, 2019

YevgeniyShunevych added a commit that referenced this issue Jun 12, 2019

#286 Fix IUIComponentVerificationProviderExtensions.Exist method to t…
…hrow AssertionException instead of NoSuchElementException; Update tests correspondingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.