New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid - selectAll method sends incorrect rowSelect event signature #148

Closed
marcbonner opened this Issue Sep 15, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@marcbonner

marcbonner commented Sep 15, 2017

When selectAll (and unSelectAll) method is run, it's calling gj.grid.methods.selectRow($grid, data, $row, $grid.get($row.data('position')));

The event signature calls for (e, $row, id, record). It's returning the 'record' object as 'id'.

I've modified the method for myself, but fear it will be lost on your next update:
selectAll: function ($grid) {
var data = $grid.data();
$grid.find('tbody tr[data-role="row"]').each(function () {
var $row = $(this);
var $data = $grid.get($row.data('position'));
gj.grid.methods.selectRow($grid, data, $row, $data.ID, $data);
});
$grid.find('thead input[data-role="selectAll"]').prop('checked', true);
return $grid;
},

@marcbonner marcbonner changed the title from selectAll method sends incorrect rowSelect event signature to Grid - selectAll method sends incorrect rowSelect event signature Sep 15, 2017

@atatanasov

This comment has been minimized.

Show comment
Hide comment
@atatanasov

atatanasov Oct 13, 2017

Owner

We fixed that in the new development version. Thanks for the contribution.

Owner

atatanasov commented Oct 13, 2017

We fixed that in the new development version. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment