Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailTemplate and downloadCSV not working together #467

Closed
IsaaacD opened this issue Nov 29, 2018 · 3 comments
Closed

detailTemplate and downloadCSV not working together #467

IsaaacD opened this issue Nov 29, 2018 · 3 comments

Comments

@IsaaacD
Copy link

@IsaaacD IsaaacD commented Nov 29, 2018

When detailTemplate is added and you try to use the downloadCSV method, an exception is thrown on the first column because it's not hidden and it does not have either a title or field attribute. This should be a simple fix to add these attributes or exclude this column when a detailTemplate is present.

image

@IsaaacD
Copy link
Author

@IsaaacD IsaaacD commented Nov 29, 2018

I was able to skirt the issue with these changes
image

I could potentially create a PR but i'm just currently modifying a local copy for a project I'm working on

@IsaaacD
Copy link
Author

@IsaaacD IsaaacD commented Nov 29, 2018

Found a better solution that can be implemented to declared columns too (for action buttons and the like)
image

atatanasov pushed a commit that referenced this issue Dec 6, 2018
@atatanasov atatanasov closed this in e83b3ef Dec 6, 2018
@atatanasov
Copy link
Owner

@atatanasov atatanasov commented Dec 6, 2018

This is fixed in the new development version. You can find the new stable build at https://github.com/atatanasov/gijgo/tree/1.9/dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants