This repository has been archived by the owner on May 10, 2019. It is now read-only.
fix for (null) at the end of the signing key #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2013 11:25
…e in step 1 of reverse auth. Prior to this fix the signing key had '(null)' appended to the end and the signature was invalid every time
… the 'oauth_callback' parameter
lorenbrichter
pushed a commit
that referenced
this pull request
Feb 21, 2013
fix for (null) at the end of the signing key
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix for scenarios in which there is no auth token secret. For instance in step 1 of reverse auth. Prior to this fix the signing key had '(null)' appended to the end and the signature was invalid every time.
All this fix does is use the empty string for the auth token secret when one exists, instead of using '(null)'.
Thanks!
Andrew