Fix two issues
Thanks for the great library!
Hi @aterrien, anything you need me to change for this to get accepted? I think these are useful fixes.
Hi Aeon, first, thank you for this patch.
It don't work correctly for me with keyup/down on the input field.
Tested with data-step=.2 and data-value=9.5
(I think we can write a function for the parseFloat rounding)
@aterrien ok, I will try to debug and find the issue, will send you update when I figure it out.
I fixed the keyboard navigation issue for decimal range, can you take a look now and try again?
hi @aterrien, any feedback?
+1 to getting this fixed
Nice addition! One little problem, though: keyboard-input. When entering a value, the decimal sign (dot) is not allowed
@aterrien, any changes you wish me to make to get this merged?
rebased off current master to make sure it merges cleanly. Let me know if anything is an issue.
Why isn't decimal support added on master?
I don't know; I guess @aterrien hasn't had time to review it.
How would you go about adding support for decimal input? I.e. allow the "." key
fix issues when the input step is decimal
for example, range is from 0 to 1 and step 0.1
fix issues when the range is negative
for example, -10 to 0 with step 1
add decimal and negative range examples to documentation
permit decimal point in text input
Rebased off master for clean merge.
@waissbluth: Added decimal point support in text field input in fe24551
I think there's still issues with negative ranges though, specifically the arrow key increment/decrement doesn't work quite right. I'll see if I can track it down soon.
Fix decimal values #78 @Aaon
Merged from your patch Aeon + had some new issues, let me know if it work as expected.
@aterrien: i don't think you merged whole branch? I don't see rest of commits merged in?
@aterrien: the decimal input commit is not sufficient, you really need the other commits for the decimal range to work.
This is great but it still seems to display imprecise decimal values like 12.1000000000001 in the middle of the dial, i.e. the "decimal problem."
I got the latest version of jquery.knob.js and merged in the not already added changes from the four commits from Aeon. All is working except a mouseclick on the dial. This returns a "NaN" error inside the dial. Where can I find this event and correct this behaviour?