fix: fix some internal type issues

atheck · Nov 16, 2022 · 54fedb6 · 54fedb6
1 parent 974f946
commit 54fedb6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Testing/renderWithModel.ts b/src/Testing/renderWithModel.ts
@@ -10,7 +10,7 @@ import { RenderWithModelOptions, setFakeOptions } from "./fakeOptions";
  * @param {(TModel | RenderWithModelOptions<TModel, TMessage>)} options The model or an options object.
  * @returns {TResult} The returned value of the `render` function.
  */
-function renderWithModel<TModel, TMessage extends Message, TResult> (render: () => TResult, options: TModel | RenderWithModelOptions<TModel, TMessage>): TResult {
+function renderWithModel<TModel extends object, TMessage extends Message, TResult> (render: () => TResult, options: TModel | RenderWithModelOptions<TModel, TMessage>): TResult {
     if ("model" in options && "dispatch" in options) {
         setFakeOptions(options as RenderWithModelOptions<unknown, Message>);
     } else {

diff --git a/src/useElmish.ts b/src/useElmish.ts
@@ -160,9 +160,8 @@ function callUpdate<TProps, TModel, TMessage extends Message> (update: UpdateFun
 }
 
 function callUpdateMap<TProps, TModel, TMessage extends Message> (updateMap: UpdateMap<TProps, TModel, TMessage>, msg: TMessage, model: TModel, props: TProps): UpdateReturnType<TModel, TMessage> {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error -- We know that msg fits
-    const updateFn = updateMap[msg.name as TMessage["name"]] as (msg: TMessage, model: TModel, props: TProps) => UpdateReturnType<TModel, TMsg>;
+    const msgName: TMessage["name"] = msg.name;
+    const updateFn = updateMap[msgName] as (msg: TMessage, model: TModel, props: TProps) => UpdateReturnType<TModel, TMessage>;
 
     return updateFn(msg, model, props);
 }