broader kill line with custom timeout #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `os_klinechan.c` module is quite handy to deal with bad users, but it is a little specific in the way it works. It bans the full user@host hostmask and does so for a single day. For prolonged botnet attacks, this is not very practical. This patch broadens the banned hostmask to cover *all* users on the attacker's IP address, so that rotating the username is not sufficient to bypass the ban. This means more possible collateral damage, but I think it's a good tradeoff considering we use this module to deal with botnet attacks, for which we ban whole networks anyways. Also, the timeout was hardcoded to one day. That seems awfully short when dealing with prolonged attacks. Instead of hardcoding another value, let's reuse the value from `SET KLINETIME` so that opers can actually customize that setting.
|
I will tidy this up at some point in the near future but this is good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
os_klinechan.cmodule is quite handy to deal with bad users, butit is a little specific in the way it works. It bans the full
user@host hostmask and does so for a single day. For prolonged
botnet attacks, this is not very practical.
This patch broadens the banned hostmask to cover all users on the
attacker's IP address, so that rotating the username is not sufficient
to bypass the ban. This means more possible collateral damage, but I
think it's a good tradeoff considering we use this module to deal with
botnet attacks, for which we ban whole networks anyways.
Also, the timeout was hardcoded to one day. That seems awfully short
when dealing with prolonged attacks. Instead of hardcoding another
value, let's reuse the value from
SET KLINETIMEso that opers canactually customize that setting.