Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix GroupServ issues #432
This pull request eliminates issues arising from hardcoded parsing of flags in the GroupServ flags parser. The GroupServ FLAGS help text is updated to reflect the now functional GroupServ flag +A (allows viewing of group access list). Additionally, issues with flags +* are fixed and now the behaviour is more consistent with that of ChanServ.
More details are available in the individual commit messages.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
To get it closer to ChanServ, there is a pre-existing quirk that should probably be addressed: if a FLAGS command is issued on a user who is not a member of the target group, and the flags string provided results in no flags being allocated to the user (eg.
ChanServ's FLAGS performs a check on the flagstring and fails the command if there are no valid flags. In addition, it will never leave a chanacs line with no flags.