Several minor UI improvements#57
Merged
jeroenvandijk merged 10 commits intoathensresearch:masterfrom May 18, 2020
Merged
Conversation
Before, they were shown as "12/31/1969, 7:00:00 PM". The new text is shown in dark gray. I've also re-formatted style.cljs.
Shows a "Loading script..." while the JS loads, as that can take a bit. Otherwise, the user would just see a blank screen. It also informs the user if the JS is loading currently or the database is loading currently.
My linting tool was complaining about unordered requires, this orders them.
Contributor
jeroenvandijk
left a comment
jeroenvandijk
left a comment
There was a problem hiding this comment.
Thank you. I left some comments that are up for discussion. Can you check what you think @Smittyvb?
Contributor
Author
|
@jeroenvandijk I've removed the Roam reference, and switched to functions instead of classes. |
jeroenvandijk
approved these changes
May 18, 2020
Contributor
jeroenvandijk
left a comment
jeroenvandijk
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
* style: display invalid dates as (unknown date) Before, they were shown as "12/31/1969, 7:00:00 PM". The new text is shown in dark gray. I've also re-formatted style.cljs. * style: alternate gray and white on pages table * feat: no blank screen during JavaScript loading Shows a "Loading script..." while the JS loads, as that can take a bit. Otherwise, the user would just see a blank screen. It also informs the user if the JS is loading currently or the database is loading currently. * style: add a small gap between left sidebar links * refactor: order requires alphabetically My linting tool was complaining about unordered requires, this orders them. * fix: remove Roam reference while loading * refactor: use merging functions instead of classes Co-authored-by: Jeroen van Dijk <jeroentjevandijk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This incorporates several minor UI changes:
style.cljsis now formatted idomatically.0instead of an actual date. These are now displayed as "(unknown date)" in a dark gray.