New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish plugin on JetBrains' repository #10

Open
GauthierPLM opened this Issue Sep 15, 2015 · 12 comments

Comments

Projects
None yet
9 participants
@GauthierPLM

For a better visibility of the plugin and an easier install process, it could be good to publish it on JetBrains' repo and/or contact the author to have rights to update its plugin.

@vrcca

This comment has been minimized.

Show comment
Hide comment
@vrcca

vrcca Feb 18, 2016

+1

Name proposal: IBM Key Promoter v2 Advanced Plus

vrcca commented Feb 18, 2016

+1

Name proposal: IBM Key Promoter v2 Advanced Plus

@evmin

This comment has been minimized.

Show comment
Hide comment

evmin commented Jul 21, 2016

+1

@alexanderfefelov

This comment has been minimized.

Show comment
Hide comment
@halirutan

This comment has been minimized.

Show comment
Hide comment
@halirutan

halirutan Jan 1, 2017

I just helped someone on IRC and found out that the official KeyPromoter is outdated and that this repo contains a better resource. Please consider pushing this to the Jetbrains repo as it will help increase visibility very much! +1

I just helped someone on IRC and found out that the official KeyPromoter is outdated and that this repo contains a better resource. Please consider pushing this to the Jetbrains repo as it will help increase visibility very much! +1

@LukasRypl

This comment has been minimized.

Show comment
Hide comment
@LukasRypl

LukasRypl Jan 2, 2017

It seems that all you (@athiele) need to do is change the plugin name and upload the latest version zip file to https://plugins.jetbrains.com/ (near the top right corner - Upload plugin)

It seems that all you (@athiele) need to do is change the plugin name and upload the latest version zip file to https://plugins.jetbrains.com/ (near the top right corner - Upload plugin)

@Kisty

This comment has been minimized.

Show comment
Hide comment
@Kisty

Kisty Jan 2, 2017

Perhaps, it would be courteous to contact the original maintaner first. If he allows it, I think it would be a lot better. You could even ask that your repo updates to his therefore not needing to upload as a new plugin and everyone that has the plugin from the original maintainer gets the latest version. Not sure how but it could be possible. Would avoid confusion against the two versions.

Kisty commented Jan 2, 2017

Perhaps, it would be courteous to contact the original maintaner first. If he allows it, I think it would be a lot better. You could even ask that your repo updates to his therefore not needing to upload as a new plugin and everyone that has the plugin from the original maintainer gets the latest version. Not sure how but it could be possible. Would avoid confusion against the two versions.

@halirutan

This comment has been minimized.

Show comment
Hide comment
@halirutan

halirutan Jan 2, 2017

@LukasRypl The leaves us with two "Key Promoters" in the repository and confuses people even more.

The best course of action is

  1. contact the original developer and explain what you did and whether he is OK that you continue his Jetbrains Keypromoter repository. I believe a change of ownership can be made possible with the help of Jetbrains.

  2. If he does not respond, I would contact plugins-admin at jetbrains.com and ask them if they can help. I think when they see how many contributions and fixes @athiele made in the meantime, they may consider a change of ownership anyway.

@LukasRypl The leaves us with two "Key Promoters" in the repository and confuses people even more.

The best course of action is

  1. contact the original developer and explain what you did and whether he is OK that you continue his Jetbrains Keypromoter repository. I believe a change of ownership can be made possible with the help of Jetbrains.

  2. If he does not respond, I would contact plugins-admin at jetbrains.com and ask them if they can help. I think when they see how many contributions and fixes @athiele made in the meantime, they may consider a change of ownership anyway.

@TheBestPessimist

This comment has been minimized.

Show comment
Hide comment
@Dgc2002

This comment has been minimized.

Show comment
Hide comment
@Dgc2002

Dgc2002 Jun 20, 2017

Just going to refresh the +1 counter here

Dgc2002 commented Jun 20, 2017

Just going to refresh the +1 counter here

@halirutan

This comment has been minimized.

Show comment
Hide comment
@halirutan

halirutan Jun 21, 2017

I copied the repository, fixed the Gradle build and carefully added credits to everyone involved. I wrote a mail to Jetbains if it is possible to take over the original Plugin so that we don't have two plugins showing up in the IDEA plugin list.

If this is OK with everyone, I would step up and maintain this nice plugin. I'm not sure how much time I can spend on it, but I'm active and available in the foreseeable future. I can merge pull requests and since the code base is not large, I'm sure we can fix some bugs.

I copied the repository, fixed the Gradle build and carefully added credits to everyone involved. I wrote a mail to Jetbains if it is possible to take over the original Plugin so that we don't have two plugins showing up in the IDEA plugin list.

If this is OK with everyone, I would step up and maintain this nice plugin. I'm not sure how much time I can spend on it, but I'm active and available in the foreseeable future. I can merge pull requests and since the code base is not large, I'm sure we can fix some bugs.

@GauthierPLM

This comment has been minimized.

Show comment
Hide comment
@GauthierPLM

GauthierPLM Jun 21, 2017

I think it would be good. This plugin can be really useful and need someone to take care of. If you think you can maintain it, it would be really nice. I think it doesn't need too much work but having someone taking care of it is always good.

I think it would be good. This plugin can be really useful and need someone to take care of. If you think you can maintain it, it would be really nice. I think it doesn't need too much work but having someone taking care of it is always good.

@halirutan

This comment has been minimized.

Show comment
Hide comment
@halirutan

halirutan Jul 1, 2017

I am now an additional developer of the original Key Promoter and I will publish a recent built soon. While I was waiting for the response of Jetbrains, I carefully looked through the code. There are issues that we won't be able to fix. Most of them are connected to the custom pop-ups that forcibly draw over IDEA itself and sometimes lead to situations where

  • they become sticky
  • they do not vanish until a modal dialogue of IDEA is closed
  • the animation doesn't work

Therefore, I sat down and rewrote 90% of the code using IntelliJ's own notification system. I know that you love to set colours, timeouts and fonts, but I was sacrificing that for non-intrusive tips that incorporate 100% into the IDEA framework. Inventive as I am, I called it Key Promoter X. I did not simply want to remove all those colour features from the original code which is the reason why I chose to create a new plugin with almost the same name.

The good thing is that I implemented additional features that I'm sure you will like:

  • automatically updating, sorted list of your missed shortcuts
  • no dialogues that force you to react, but only clickable notifications
  • you can suppress individual buttons that you never want to see a tip for, and you see them in a "suppressed button list"
  • on OSX menu entries (which are kind of special) are working as well

You will find the "Key Promoter X" when you browse plugins inside IDEA. Hope you like it.

I am now an additional developer of the original Key Promoter and I will publish a recent built soon. While I was waiting for the response of Jetbrains, I carefully looked through the code. There are issues that we won't be able to fix. Most of them are connected to the custom pop-ups that forcibly draw over IDEA itself and sometimes lead to situations where

  • they become sticky
  • they do not vanish until a modal dialogue of IDEA is closed
  • the animation doesn't work

Therefore, I sat down and rewrote 90% of the code using IntelliJ's own notification system. I know that you love to set colours, timeouts and fonts, but I was sacrificing that for non-intrusive tips that incorporate 100% into the IDEA framework. Inventive as I am, I called it Key Promoter X. I did not simply want to remove all those colour features from the original code which is the reason why I chose to create a new plugin with almost the same name.

The good thing is that I implemented additional features that I'm sure you will like:

  • automatically updating, sorted list of your missed shortcuts
  • no dialogues that force you to react, but only clickable notifications
  • you can suppress individual buttons that you never want to see a tip for, and you see them in a "suppressed button list"
  • on OSX menu entries (which are kind of special) are working as well

You will find the "Key Promoter X" when you browse plugins inside IDEA. Hope you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment