Tuya Fan Support #14
Merged
Tuya Fan Support #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeeJeWel
requested changes
Jun 9, 2024
lib/TuyaOAuth2DriverFan.js
Outdated
| * @extends TuyaOAuth2Driver | ||
| * @hideconstructor | ||
| */ | ||
| class TuyaOAuth2DriverLight extends TuyaOAuth2Driver { |
There was a problem hiding this comment.
Can you rename this to TuyaOAuth2DriverFan?
drivers/fan/pair/select_country.html
Outdated
| @@ -0,0 +1,160 @@ | |||
| <style type="text/css"> | |||
There was a problem hiding this comment.
This file is not used anymore. Can you remove it?
|
Changes made and should be ready to be accepted |
|
Amazing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Fan device/driver support for the Tuya App