Skip to content
This repository has been archived by the owner. It is now read-only.

Apps: settings not saved on first call #600

Closed
irritanterik opened this issue May 13, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@irritanterik
Copy link

commented May 13, 2016

What is your Homey version (Settings → System)?

0.8.34

Wht did you try to achieve?

Save app settings from an apps settings page.

What was the result?

Settings saved, but callback function not called.

Any other remarks
This breaks every app with a settings page that waits for this callback.

First Homey.set call from a settings page after pageload does not save settings and execute callback.
step 1: Load a settings page and execute this in console:
Homey.set('test', 3, function (error, result) { console.log(error, result) } )
result: setting saved, no callback executed
step 2: Execute command again (without reloading settings page)
result: setting saved, callback executed

@irritanterik

This comment has been minimized.

Copy link
Author

commented May 13, 2016

Updated this issue: settings are saved, but callback is not executed on first save (after a settings page load)

@WeeJeWel

This comment has been minimized.

Copy link
Contributor

commented May 16, 2016

Fixed in 0.8.35. Also renamed Homey.getAll(cb) to Homey.get(cb) (when no name found, return all)

@WeeJeWel WeeJeWel added this to the 0.8.35 milestone May 16, 2016

@daneedk

This comment has been minimized.

Copy link

commented May 16, 2016

@WeeJeWel will 0.8.35 be released asap as a fix firmware for the problems introduced in 0.8.34 or will it be the planned 0.8.35 (with the new flow editor etc.) includings these fixes?

@WeeJeWel

This comment has been minimized.

Copy link
Contributor

commented May 16, 2016

0.8.35 will be released within a few days as hotfix release, with the Flow folders as bonus ;)

@daneedk

This comment has been minimized.

Copy link

commented May 16, 2016

That's good news, great! Thank you!

@irritanterik

This comment has been minimized.

Copy link
Author

commented May 20, 2016

Confirmed fixed with 0.8.35

@WeeJeWel WeeJeWel closed this May 20, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.