-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI + Use GitHub Actions to run the tests on Windows #287
Conversation
@@ -1,39 +0,0 @@ | |||
GEM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the lock file generated on Windows is not compatible with the lock file generated on Linux, and vice versa. If you want to use a fixed set of versions, it is better to fix the versions in Gemfile itself.
This last commit fixes the failing test on the master branch. It is the same one that I mentioned in |
This uses GitHub Actions to install LLVM, set up the environment, and build and test Dpp.
Here is an example of a successful run:
https://github.com/aminya/dpp/actions/runs/865871754