Fix CI + Use GitHub Actions to run the tests on Windows #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atilaneves
reviewed
May 24, 2021
| @@ -1,39 +0,0 @@ | |||
| GEM | |||
There was a problem hiding this comment.
Because the lock file generated on Windows is not compatible with the lock file generated on Linux, and vice versa. If you want to use a fixed set of versions, it is better to fix the versions in Gemfile itself.
|
This last commit fixes the failing test on the master branch. It is the same one that I mentioned in |
Merged
aminya
changed the title
atilaneves
reviewed
May 26, 2021
atilaneves
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses GitHub Actions to install LLVM, set up the environment, and build and test Dpp.
Here is an example of a successful run:
https://github.com/aminya/dpp/actions/runs/865871754