Fix JsBlock refactor #2019
Merged
Fix JsBlock refactor #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
requested changes
Mar 6, 2023
There was a problem hiding this comment.
Shouldn't this be detected by
Line 21 in 3c592b8
Before merging this, I would like to have an explanation why this is not detected by phpstan or if we can help phpstan to detect it in general.
|
repro: https://phpstan.org/r/7cfa9ded-de04-4bb7-828a-4be9b048baf9 phpstan issue: phpstan/phpstan#9006 |
mvorisek
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missed refactoring for JsBlock