Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/#487-Modal Behaviour #496

Merged
merged 3 commits into from Jun 19, 2018
Merged

fix/#487-Modal Behaviour #496

merged 3 commits into from Jun 19, 2018

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jun 18, 2018

Fix multiple modal positioning when using multiple modal;

  • Modals under top modal opacity are set to 0, they look hidden but they are still available.
    • this is need for modalServices to work properly.
    • We can set the opacity value to an higher number if the intent is still be able to see under modals.
  • Proper positioning is done by setting position value to absolute.
  • Fix the esc key behaviour. Simply adding our own esc event in modal service.

Update modal2.php demos files in order to show modal at three level deep.

Note

atkjs-ui need to be rebuild.

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #496 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #496   +/-   ##
==========================================
  Coverage      65.71%   65.71%           
  Complexity      1568     1568           
==========================================
  Files             88       88           
  Lines           3754     3754           
==========================================
  Hits            2467     2467           
  Misses          1287     1287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b3b7c...752ca07. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works really well. Haven't tested with CRUD in modal yet.

@romaninsh romaninsh merged commit ab67872 into develop Jun 19, 2018
@romaninsh romaninsh deleted the fix/#487-Modal branch June 19, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants