New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garrettcook patch #598

Closed
wants to merge 10 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@garrettcook
Copy link

garrettcook commented Nov 20, 2018

Addresses https://forum.agiletoolkit.org/t/addfiltercolumn-causes-fatal-error/564. Also now allows filtering on field of type "text".

garrettcook added some commits Nov 16, 2018

@romaninsh

This comment has been minimized.

Copy link
Member

romaninsh commented Nov 20, 2018

is renaming namespaced "Generic" class into "FilterGeneric" beneficial in some way?

@DarkSide666

This comment has been minimized.

Copy link
Member

DarkSide666 commented Nov 20, 2018

I don't see any advantage of this renaming (except adding TypeText which is good).

Also your example doesn't give me error.

Try creating this file in in /demos folder and run it - no errors:

require 'init.php';
require 'database.php';

$view = $app->add('View', ['ui' => 'basic segment']);
$g = $view->add(['Grid']);
$m = new Country($db);

$g->setModel($m);
$g->addFilterColumn();

So maybe there is something wrong with your other code or other composer dependency which is not namespaced and contains Generic class.
Can you show us your composer.json file and also your myModel class.

@DarkSide666 DarkSide666 self-requested a review Nov 20, 2018

@garrettcook

This comment has been minimized.

Copy link
Author

garrettcook commented Nov 21, 2018

Github won't let me attach the composer.json file, but it is the same as what comes with 1.6.0. What is meant by myModel class?

@DarkSide666

This comment has been minimized.

Copy link
Member

DarkSide666 commented Nov 22, 2018

Did my example above work fine for you?
If it work fine, then please try to make it fail and post it here so I can see what's wrong with it. Try to keep test case as simple as possible to show me your error.

@garrettcook

This comment has been minimized.

Copy link
Author

garrettcook commented Nov 26, 2018

I don't have the default database set up and maybe there's some problem with another control I'm using. For now we can just set aside my namespace issue and merge the new TypeText.php file.

@romaninsh

This comment has been minimized.

Copy link
Member

romaninsh commented Nov 28, 2018

PHP Fatal error: Cannot declare class atk4\ui\TableColumn\FilterModel\Generic, because the name is already in use in /home/travis/build/atk4/ui/src/TableColumn/FilterModel/FilterGeneric.php on line 14

from test-suite.

@romaninsh romaninsh closed this Dec 4, 2018

@romaninsh

This comment has been minimized.

Copy link
Member

romaninsh commented Dec 4, 2018

lack of activity and communication.

@garrettcook

This comment has been minimized.

Copy link
Author

garrettcook commented Dec 5, 2018

Does this mean the change will not be implemented? I thought the test-suite example indicated that the issue was present outside of just my environment,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment