Fix/UserAction Validation error #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly catch Data Validation error in UserAction executor.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. |
|
Not sure what it does and why. |
This is to give better information on error by including the action name in error message. |
romaninsh
added a commit
that referenced
this pull request
Mar 30, 2020
* Apply fixes from StyleCI * Code review Add comments clean up. * Apply fixes from StyleCI * update comment * test * fix test uri for jsactions.php demo * init * merge changed * Apply fixes from StyleCI * update View::on() Add ability to setup apiConfig for jsCallback. * updated Fix dropdown when place inside a column table. * Apply fixes from StyleCI * fix typo * update method name * improve functionality and demos * Apply fixes from StyleCI * improve demo * Apply fixes from StyleCI * improve demo * improve demo * making crud work * fixes * integrated crud into actions * Apply fixes from StyleCI * Code review Add comments clean up. * Apply fixes from StyleCI * update comment * test * fix test uri for jsactions.php demo * init * merge changed * Apply fixes from StyleCI * update View::on() Add ability to setup apiConfig for jsCallback. * merge * updated Fix dropdown when place inside a column table. * Apply fixes from StyleCI * fix typo * update method name * improve functionality and demos * Apply fixes from StyleCI * improve demo * Apply fixes from StyleCI * improve demo * improve demo * crud improvements * wip * wip * Apply fixes from StyleCI * action test * Apply fixes from StyleCI * test with getting action * Apply fixes from StyleCI * change property name * setup executor from action * Apply fixes from StyleCI * Addesd public property currency_decimals in Persistence/UI * Using property currency_decimals in FormField/Money * Apply fixes from StyleCI * code cleanup * refactor and review * Apply fixes from StyleCI * clean up * add hook callback to crud * Apply fixes from StyleCI * adding native action dropdown support into crud * Apply fixes from StyleCI * update demo to contain example of redefining action executor * Apply fixes from StyleCI * Added two really nice demo pages (index and actions) * Apply fixes from StyleCI * fixed and enhancement - fixed table border - fixed js when table dropdown menu appear near end of window - Delete action should be fixed in atk4\data remove floating css class to table dropdown menu View::On method now check for action confirmation property and apply it by default * fix action in wizrd * add action to menu item * add UserConfirmation * Apply fixes from StyleCI * Add SSE operation with user confirmation example This adds an example for triggering an SSE operation after asking confirmation from the user. * Apply fixes from StyleCI * hide modal content while reloading * refactor make it more generic by applying class to loader instead of moda. * apply sorting when using action * Apply fixes from StyleCI * remove previous test * remove tutorial from actions page Added to a new page tutorial_actions for test to work again * fix double factory * Fix few bugs and add comments (#847) * add some comments while reviewing * fix action->fields bug * cleanup * CRUD refactoring * Apply fixes from StyleCI * change method name * minor fix * notify refactor * more refactoring * Apply fixes from StyleCI * more cleanup * fix comment * more cleanup * Apply fixes from StyleCI * fix actions test * fix lookup test * temp fix for lookup Seem like db value is not available. * Feature/Code Highlight (#849) * Feature/Code Highlight Display code in tutorial using Highlight.js * Apply fixes from StyleCI * add lang selection * fix * nothing * Feature/Card Deck using model action (#846) * init * Apply fixes from StyleCI * fix demo * enhancement add menu bar improve jsNotify setup * Apply fixes from StyleCI * add ability to pass View::on() defaults * add some comments while reviewing * fix action->fields bug * cleanup * CRUD refactoring * Apply fixes from StyleCI * change method name * minor fix * notify refactor * more refactoring * Apply fixes from StyleCI * more cleanup * fix comment * more cleanup * Apply fixes from StyleCI * fix actions test * fix lookup test * temp fix for lookup Seem like db value is not available. * deck refactoring * Apply fixes from StyleCI * update demo * Apply fixes from StyleCI * typo * Apply fixes from StyleCI * enhancement card template refactoring add itemSearch to deck * Apply fixes from StyleCI * add empty view when no record to show * Apply fixes from StyleCI * update * Apply fixes from StyleCI * apply partial reload on card when possible * Apply fixes from StyleCI * remove test argument * Code review * Apply fixes from StyleCI * create view from seed * nothing really * Add Github workflows (actions) (#848) * workflow * Setting current dependencies * wip * wip * wip * wip * wip * wip * wip * wip * fix * Fix unit test on Windows paths * Remove file db.github.php from Demo functional test check. * Apply fixes from StyleCI * Fix some Type Hints * Apply fixes from StyleCI * Feature/input action (#845) * Feature/Input Action * Apply fixes from StyleCI * Change in demo : exit() to $app->callExit() (#854) * Change exit() to $app->callExit() * Change direct exit call to $app->callExit(). * Change all deprecated Persistence_* to correct Persistence\* * badge * fix release bundler * fix release bundler * wip * fix release bundler * fix release bundler * fix release bundler * fix release drafter * release drafter fix * Improvement/include action caption in modal title (#852) * include action caption in modal title * [UPDATE] trim modal title * Apply fixes from StyleCI * DateTime is object and working on same object is replacing both value… (#834) * DateTime is object and working on same object is replacing both values to be same This sets $d1 and $d2 both to "YYYY-mm-dd 23:59:59" ... * Apply fixes from StyleCI * Add Instantiate App using DIContainerTrait (#855) * Cleanup actions * categorizing release drafter * categorizing release drafter * add bot that would ask for documentation * cleanup * fix release bundler * fix release bundler * fix indentation to 2 spaces * fix bundler * Release/2.0.1 backport. (#862) * Releasing 2.0.0 into master (manually) (#859) * Apply fixes from StyleCI * remove extra spaces from Response Content-Type * enhanced only call server when using expression in row. * code review review hasExpression function * First scratch for multiline Documentation * add semantic-ui-vue in atkjs bundle * update webpack configuration * Better draft, formatting and Screenshots follow * Add some formatting * Update Formatting * Add Multiline Screenshots * Fix Link to Screenshot * Add ability to customize CSS of 'content' div * Add Documentation for addContentCss() feature * Added Expressions, onLineChange() * Chapter "Changing appearance" * Improve formatting * update doc * add "Is Not" for TableColumn::FilterModel::TypeString * StyleCI * changed Css to CSS (similarly how we use e.g. renderJS) * add demo * Apply fixes from StyleCI * Add a Scrolling Modal * minor fix change function name. * remove useSuiVue Now include in Bundle * fix/CaughException Layout - When children App is created * Bump eslint-utils from 1.4.0 to 1.4.2 in /js Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.2. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.2) Signed-off-by: dependabot[bot] <support@github.com> * Update to changes in Modal.php * add ignore E_DEPRECATED & E_USER_DEPRECATED * add App->catch_error_types to define error types in set_error_handler * fix/#802 Array fields error in form * Apply fixes from StyleCI * Fix #8ß5 * Allow to add Attributes to <input> tag New property added: $this->inputAttr in which additional attributes are stored New function added: setInputAttr() which is a clone of View->setAttr() which fills the $this->inputAttr array Can also be used to overwrite existing attributes as $this->inputAttr is passed as second param to array_merge (at $this->app->getTag()) * update to use inputAttr * update to use inputAttr * update to use inputAttr * update to use inputAttr * style CI fixes * styleCI fixes * Add demo for custom <input> Attributes * add another demo field which uses array definition * Update TypeText.php to pass check * Fix autocomplete.html * Fix lookup.html * Fix autocomplete.pug * Fix lookup.pug * init - add jsCallback when adding or deleting a row. * feature/TreeItemSelector Form Field Initial commit * Apply fixes from StyleCI * Make Escape key clear Grid Search * feature/MultiLine Enhancement - Ability to run js when adding or deleting row. - Add new line of record when tabbing out of the last row/column * Apply fixes from StyleCI * start implementation * Apply fixes from StyleCI * remove test * changed example for ibelar * Apply fixes from StyleCI * some more notes wip * Apply fixes from StyleCI * test * Mutliline: Improve inline docs and comments (#811) * Improve inline docs and comments * Update MultiLine.php * initial testing * Fix #814 - useless code in Form.php (#818) * Fix #814 - useless code in Form.php * Update Form.php * Add Locale class * Apply fixes from StyleCI * add LocaleTest * Apply fixes from StyleCI * Update LocaleTest.php * Add credits to Lokalize services * Create .empty * Delete .empty * Fix Locale.php * refactor * code review and refactor * Apply fixes from StyleCI * updare demo * type hint and cleanup * Apply fixes from StyleCI * js cleanup and comment * add more demo * Typo. * update userAction move loader set function to jsRender so we could apply afterSuccess or jsSuccess after setAction is done. Add jsSuccess and stateContext * Apply fixes from StyleCI * fix * Feature/fix textarea (#822) * fix TextArea and DropDown zero and empty values * Apply fixes from StyleCI * Enhance Form Testing suite * Apply fixes from StyleCI * fix * fix * #823: Fix a few phpDoc comments. (#824) * #823: Fix a few phpDoc comments. * #824: Lowercase @inheritdoc . * update - include web storage for ajaxexec - code refactoring * fix modal service * update modal service * fix/DropDown unnecessary property Remove unneccessary property isValueRequired for dropdown formfield and rely on field property required instead. * update ajaexec.plugin add demos/test to gitignore * remove unused comment * update button placement and state * remove jsEvent executor from UserAction Action that required an event must be expicitly set using jsEvent * Apply fixes from StyleCI * add exception handler * Apply fixes from StyleCI * update demos * added jsExecute() * Apply fixes from StyleCI * cleanup * check for exception in each jsSubmit step * Apply fixes from StyleCI * Feature/Refactor On method Allow for on method to receive a Model UserAction as second arguments. * Apply fixes from StyleCI * Table columns support user action now * Apply fixes from StyleCI * forgot the demo * Apply fixes from StyleCI * update - Create new Class jsUserAction based on existing jsCallback - remove jsEvent executor from demos - set demos using new jsUserAction - update View method to use new jsUserAction * Apply fixes from StyleCI * Code review Add comments clean up. * Apply fixes from StyleCI * update comment * test * fix test uri for jsactions.php demo * init * merge changed * Apply fixes from StyleCI * update View::on() Add ability to setup apiConfig for jsCallback. * updated Fix dropdown when place inside a column table. * Apply fixes from StyleCI * fix typo * update method name * improve functionality and demos * Apply fixes from StyleCI * improve demo * Apply fixes from StyleCI * improve demo * improve demo * making crud work * fixes * integrated crud into actions * Apply fixes from StyleCI * Code review Add comments clean up. * Apply fixes from StyleCI * update comment * test * fix test uri for jsactions.php demo * init * merge changed * Apply fixes from StyleCI * update View::on() Add ability to setup apiConfig for jsCallback. * merge * updated Fix dropdown when place inside a column table. * Apply fixes from StyleCI * fix typo * update method name * improve functionality and demos * Apply fixes from StyleCI * improve demo * Apply fixes from StyleCI * improve demo * improve demo * crud improvements * wip * wip * Apply fixes from StyleCI * action test * Apply fixes from StyleCI * test with getting action * Apply fixes from StyleCI * change property name * setup executor from action * Apply fixes from StyleCI * Addesd public property currency_decimals in Persistence/UI * Using property currency_decimals in FormField/Money * Apply fixes from StyleCI * code cleanup * refactor and review * Apply fixes from StyleCI * clean up * add hook callback to crud * Apply fixes from StyleCI * adding native action dropdown support into crud * Apply fixes from StyleCI * update demo to contain example of redefining action executor * Apply fixes from StyleCI * Added two really nice demo pages (index and actions) * Apply fixes from StyleCI * fixed and enhancement - fixed table border - fixed js when table dropdown menu appear near end of window - Delete action should be fixed in atk4\data remove floating css class to table dropdown menu View::On method now check for action confirmation property and apply it by default * fix action in wizrd * add action to menu item * add UserConfirmation * Apply fixes from StyleCI * Add SSE operation with user confirmation example This adds an example for triggering an SSE operation after asking confirmation from the user. * Apply fixes from StyleCI * hide modal content while reloading * refactor make it more generic by applying class to loader instead of moda. * apply sorting when using action * Apply fixes from StyleCI * remove previous test * remove tutorial from actions page Added to a new page tutorial_actions for test to work again * fix double factory * Fix few bugs and add comments (#847) * add some comments while reviewing * fix action->fields bug * cleanup * CRUD refactoring * Apply fixes from StyleCI * change method name * minor fix * notify refactor * more refactoring * Apply fixes from StyleCI * more cleanup * fix comment * more cleanup * Apply fixes from StyleCI * fix actions test * fix lookup test * temp fix for lookup Seem like db value is not available. * Feature/Code Highlight (#849) * Feature/Code Highlight Display code in tutorial using Highlight.js * Apply fixes from StyleCI * add lang selection * fix * nothing * Feature/Card Deck using model action (#846) * init * Apply fixes from StyleCI * fix demo * enhancement add menu bar improve jsNotify setup * Apply fixes from StyleCI * add ability to pass View::on() defaults * add some comments while reviewing * fix action->fields bug * cleanup * CRUD refactoring * Apply fixes from StyleCI * change method name * minor fix * notify refactor * more refactoring * Apply fixes from StyleCI * more cleanup * fix comment * more cleanup * Apply fixes from StyleCI * fix actions test * fix lookup test * temp fix for lookup Seem like db value is not available. * deck refactoring * Apply fixes from StyleCI * update demo * Apply fixes from StyleCI * typo * Apply fixes from StyleCI * enhancement card template refactoring add itemSearch to deck * Apply fixes from StyleCI * add empty view when no record to show * Apply fixes from StyleCI * update * Apply fixes from StyleCI * apply partial reload on card when possible * Apply fixes from StyleCI * remove test argument * Code review * Apply fixes from StyleCI * create view from seed * nothing really * Add Github workflows (actions) (#848) * workflow * Setting current dependencies * wip * wip * wip * wip * wip * wip * wip * wip * fix * Fix unit test on Windows paths * Remove file db.github.php from Demo functional test check. * Apply fixes from StyleCI * Fix some Type Hints * Apply fixes from StyleCI * Feature/input action (#845) * Feature/Input Action * Apply fixes from StyleCI * Change in demo : exit() to $app->callExit() (#854) * Change exit() to $app->callExit() * Change direct exit call to $app->callExit(). * Change all deprecated Persistence_* to correct Persistence\* * badge * fix release bundler * fix release bundler * wip * fix release bundler * fix release bundler * fix release bundler * Setting current dependencies * Setting current dependencies * fix release bundler * fix release bundler * fix release bundler * fix release bundler * wip * Updating CDN link to use @2.0.2 (#864) * Update versions for develop * Update App.php * Update App.php * wip * wip * Update versions for develop (#866) * Feature/enable setting custom exec button for an action (#853) * enable setting custom exec button for an action * use seed instead of object * Apply fixes from StyleCI * Added namespaces to quickstart and file structure example (#857) * Added namespaces to quickstart and file structure example I adapted and enhanced the things that have been missing for myself when I started using atk. So I first had to dig into namespaces and second I had to experiment with the file structure until I came up with one that is suited for small and big projects and offers a good overview and structure. * Updated filestructure and adapted to PSR-4 namespace conventions I did some adaptions of the namespacing as it wasn't fully PSR-4 conform. In addition some changes to the file structure. Vendor is now outside of the public folder. * develop should require develop * use getFields() instead of elements property (#876) * use getFields() * Apply fixes from StyleCI * nicer * Apply fixes from StyleCI * move jsInput, add jsChecked (#879) * move jsInput, add jsChecked * Apply fixes from StyleCI * Fix/UserAction in VirtualPage and Tabs (#880) * testing * use minified * more testing * testing 33 * fix getmodal * finall * Apply fixes from StyleCI * remove test * remove comment * Apply fixes from StyleCI * fix typo * fix comment * fix unit test UsertAction modal executor is now add into $app->html view instead of layout. * fix version number * Use new view method for rendering js action * back to min js version * Update versions for develop (#881) Co-authored-by: GitHub Web Flow <noreply@github.com> * Feature/Card Field default (#883) Use all visible field by default in card * introduce record specific enabling/disabling of actions in Grid/CRUD (#874) * introduce record specific enabling/disabling of actions in Grid/CRUD * update comments of methods * add code comments * Apply fixes from StyleCI * allow use of any callable * Apply fixes from StyleCI * update classes in comments * Apply fixes from StyleCI * set model on initialization (#884) * set model on initialization * Apply fixes from StyleCI * move to View class * remove from Grid class Co-authored-by: Imants Horsts <DarkSide666@users.noreply.github.com> * fix #850 (#886) * fix #887 * Feature/update readme (#871) * updating readme file * readme updates * Fix missing EOLs in text files (#888) * Fix/CRUD onForm callback (#893) * Fix/CRUD onForm callback Fix callback for Form. Was broken by PR#880 - Refactor some method name. - Fix CRUD demos/crud.php * Apply fixes from StyleCI * Fix/Enable Callback argument to stick at application (#894) * Fix/Enable Callback argument to stick at application Sometime, callback argument need to stick application wide, not just in View. This is especially true for ActionExecutor using application modal. This PR allow to create url argument that stick to application. * Set executor loader to view sticky by default * use same one-liner to shift selector column as on drag handler (#895) * usage of getFields() and fix Card (#892) * fix card getfields filter * Apply fixes from StyleCI * we should show also integer values for example * Add actionshould respect enabled/disabled switch (#898) * Fix/Table Popup - Dropdown (#900) * Fix/Table Popup - Dropdown * Apply fixes from StyleCI * Update string quotes to make the code compatible with Netbeans (#901) * fix/Demos grid.php (#905) Change to use new method name in Grid from Grid::addAction to Grid::addActionButton * Implement conditional tags in template (#899) * implement conditional tags in template * Apply fixes from StyleCI * add test and docs * change zero value treatment * docs * refactor conditional tags * Apply fixes from StyleCI * simplify * remove debug * Update indent in example in README (#906) * Trim search query in Grid component (#915) * use one liner for jQuery selector (#912) * Fix/Clear Api Data with all server response (#909) Fix: #902 * use trait for table tests (#910) * hotfix Multiline field * Fix PHP notice - field can be null (#926) * Don't render Menu if it's empty (#917) * don't render Menu if it's empty. fix #908 * Apply fixes from StyleCI * Update composer.json * cleanup * Update bundler.yml * Change Dropdown, Autocomplete and Lookup empty value to Unicode NBSP (#927) * Change AutoComplete and Lookup default limit to 100 values (#928) * Swap conditions, prevent ".." file lookup (#938) * Fix/Filter Popup test (#942) * fix/Duplicate Url encoding (#945) * fix/Duplicate Url encoding * move decodeURI function to getQueryParam * Fix TravisCI build (#931) * Do not fail-fast PHP test matrix (#937) * Update unit-tests.yml * Update unit-tests.yml * Update .travis.yml * fix icon template (and tests) * Testing PR. (#947) * Fix includes (#941) * Add __DIR__ to includes Regex: ((?<!will )(include|require)(_once)?\s+)' Replace: $1__DIR__ . '/ * Include always once if desired Regex: (include|require)(?=\s+__DIR__) Replace: $1_once * Fix include in doc * Minor alignment fix in doc * Update init.php Co-authored-by: Imants Horsts <DarkSide666@users.noreply.github.com> * Fix/Crud delete action and UserAction (#936) * Fix/Crud Delete Action Delete action executor in Crud is wrongly assign to UserAction instead of jsUserAction when editFields is set in CRUD. This will properly fix executor assignment in CRUD for delete action. * more fix Co-authored-by: Romans Malinovskis <me@nearly.guru> * Fix selector of remove prompt (#914) * Fix/UserAction Validation error (#896) * Fix/UserAction Validation error Properly catch Data Validation error in UserAction executor. * Apply fixes from StyleCI * set test web server root to package root directory (#948) * set test web server root to package root directory * fix styling * fix coverage filename * simplify to only one method * fix styling * Feature/Add properties to force js execution for actions (#953) * Feature/Add properties to force js execution for actions * uodate comment * fix style ci * [DOCS] explain setting form field default values (#952) * explain setting field default values * align code comments * Feature/tablecol labels (#958) * Labels now support $field->values labels * fix * fix CRUD menu unnecessary destruction (#957) * use regex with full string match on SSE response keys (#949) * use array casting and arguments spread (#950) * move typecasting to Field and allow DropDown towork with model field … (#961) * move typecasting to Field and allow DropDown towork with model field type=array values not just CSV * add docs * enable use of existing menu for Grid (#959) * [REFACTOR] Menu for flexibility, consistency and one-liner code (#955) * refactor Menu for flexibility, consistency and one-liner code * take care when adding object as item * fix for falsy values 0 and '0' * change 'label' with 'text' key Label has another meaning in this context * [FIX] table column actions icon (#960) * display popup icon before the column caption * refactor TableColumn\Generic code for clarity and consistency * refactor for more code clarity * resolve conflicts * fix wrap of caption and filter icon * fix typo dot to comma * refactor to use shorthand syntax (#954) * [FIX] table column actions icon full browser support (#962) * display popup icon before the column caption * refactor TableColumn\Generic code for clarity and consistency * refactor for more code clarity * resolve conflicts * fix wrap of caption and filter icon * fix typo dot to comma * update to standard css vaue for full browser range support * fix/UserAction Title (#964) Allow to set the Modal title for UserAction. - if title property is null, then will default to Action and Model caption. * Update unit-tests.yml * fix/#969 (#970) - Move Preview to last step; - Set model field to value set in Fields step for preview. * Implement $sortable property for TableColumn. (#972) * Implement $sortable property for TableColumn. * space * Some cleanup (#976) Section "Requirements" specified twice, the second one being empty. Also id 25 later in the document should be 24. * setLayout -> initLayout (#977) * Fix typo in form.rst (#988) * Add refactoring support (#929) * Improve add() method phpdoc * Add StaticAddToTrait trait to View * Use addTo method in View::add() * Fix failing tests when class name is required - add([... only Regex (case sensitive): ->add\(\['(?![A-Z]) * Fix failing tests when class name is required - other Regex: \['(u|class|template)i'\s*=> * Fix missing EOL in text files (#985) * Fix missing EOL * Trim end NL when template is loaded from a file * Add return type hint (#984) * fix #995, simplify session object in demo (#997) * fix #995, simplify session object in demo * style * [FEATURE] introduce autocomplete dependency (#951) * introduce AutoComplete dependency and multiple selection * Apply fixes from StyleCI * uprade pug template * [REFACTOR] rename addHook to onHook (#968) * rename addHook to onHook * trigger CI * fix issues with Card and CardDeck (#996) * fix issues with Card and CardDeck * style fix * style fix * Update release-drafter.yml * tabs should not highlight (#998) * fix/Js Package Dependencies (#999) * fix/Js Package Dependencies * update babel-config * release note * fix/Delete package-lock json file (#1000) * better support for arguments with model type (#1001) * better support for arguments with model type * simplify * fix add(), remove reset() * Refactor ->add() usage to ::addTo() (#991) * Migrate all ->add() with @var phpdoc * Migrate all ->add() for custom classes in demos/ * Add StaticAddToTrait trait to Template * Fix typo * Fix bad usage of add() $region * Apply manual fixes for add() migrate * Migrate all ->add() with script - excl. new obj. * Migrate all ->add() with script - new obj. / empty constructor * Migrate all ->add() with script - new obj. / array constructor * Migrate all ->add() with script - new obj. - all * Fix hook trait usage (#1003) * Refactor ->add() usage to ::addTo() in docs (#1004) * Apply manual fixes * Refactor ->add() usage to ::addTo() in docs * Fix bad add/seed usage in docs * Fix TravisCI/Behat tests (#1007) * Fix onHook usage * Fix CS * Improve ->add() - fallback is always absolute class name (#1008) * make caughtException public, sometimes it's needed * fix/jQuery var assignment (#1011) * fix adding of sub-menus (#1016) * Add concat spaces (#1019) * Add CS fixer dev dependency * Add concat spaces CS Fixer rule: {"concat_space": {"spacing": "one"}} * Update README.md * [Fix] PHP Notice Bad Index on jsCallback (#1017) * [fix] PHP Notice Bad Index on jsCallback Refactor getJsExec in jsCallabkack method. - Returning a View is not dependant of index[0] anymore when in array. Fix: #1010 * add comment * more refactoring * enable output of modal * update demo * Move return types to the code * Fix StyleCI * Use instanceof positively for better refactorability * fix selenium test * fix lookup and vue test * Add missing end NL Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz> * Do not append semicolon to statement when not needed (#1026) * Do not append semicolon to statement when not needed * also if ends with block * [Feature] Dropdown Cascade Form Field (#1012) * Feature/Dropdown Cascade Form Field * missing return * styleci * add doc and connect to renderRow callback * Fix TableColumn\Labels for null values (#1033) * Fix TableColumn\Label for null values When $field->get() returns null cast to empry Array to avoid foreach error. * Update Labels.php Co-authored-by: Imants Horsts <DarkSide666@users.noreply.github.com> * [fix] - Allow onDelete or onUpload callback to run during a callback (#1034) This fix will prevent throwing an error about onDelete or onUpload callback not been set when running within another callback. Fix: #1029 * Fix typo (#1036) * [refactor] AutoComplete into Lookup (#1018) * [refactor] AutoComplete into Lookup * setup proper file name for test * update php doc reference * Fix StyleCI * fix test * Apply fixes from StyleCI (#1032) Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz> Co-authored-by: Romans Malinovskis <me@nearly.guru> * Apply fixes from StyleCI (#1037) * Update Grid.php (#1035) Error in line 550 on 'Actions' column. * Update versions for develop * Setting current dependencies and complied JS * fix conflict problem * Delete config.yml (#939) * fomantic update 2.8.4 (#979) * bump fomantic verison * Update App.php * Add workflow for deploying "ui.agiletoolkit.org" automatically. (#873) * Added working Dockerfile * add codefresh build * fix * wip * added helm * wip * add lock file for easier install * wip * wip * wip * wip * wip * wip * Feature/improve tutorials (#872) * Improving tutorials * fix * Apply fixes from StyleCI * can update demo, that's also OK * wip * Apply fixes from StyleCI * that's not a useful file * cleaned up Actions menu and added more explanations * not sure why tthis wasn't loading * Apply fixes from StyleCI Co-authored-by: Romans Malinovskis <me@nearly.guru> Co-authored-by: Alain Belair <belair.alain@gmail.com> Co-authored-by: Thomas Stokkeland <stokkeland@gmail.com> Co-authored-by: Romans Malinovskis <romans@agiletoolkit.org> Co-authored-by: Alex Cicovic <acicovic@gmail.com> Co-authored-by: Imants Horsts <DarkSide666@users.noreply.github.com> Co-authored-by: DarkSide <imants.horsts@inbox.lv> Co-authored-by: Francesco Danti <fdanti@gmail.com> Co-authored-by: Georgi Hristov <georgehristov@users.noreply.github.com> Co-authored-by: Gowrav Vishwakarma <gowravvishwakarma@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: bedengler <himself@bedengler.com> Co-authored-by: GitHub Web Flow <noreply@github.com> Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz> Co-authored-by: NotAProfessionalDeveloper <277893+NotAProfessionalDeveloper@users.noreply.github.com> Co-authored-by: arrochado <arrochado@gmail.com> Co-authored-by: mkrecek234 <michael@krecek.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly catch Data Validation error in UserAction executor.