-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQ-22: Data contract PreProcessor #2937
Conversation
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
…er for needed attributes
* Remove version util and moved getCurrentVersion method to preprocessor * Remove unused varibles * Optimize fetching latest version of contract *
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...ache/atlas/repository/store/graph/v2/preprocessor/contract/AbstractContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Show resolved
Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
* Remove purgebyId call and remove skip auth in the purge method * Make DataContract attributes public for serialisation and deserialisation of JSON * Make minor changes for optimisation
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java
Show resolved
Hide resolved
repository/pom.xml
Outdated
<dependency> | ||
<groupId>org.hibernate</groupId> | ||
<artifactId>hibernate-validator</artifactId> | ||
<version>4.3.0.Final</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a CVE of severity medium here! please fix it. Can't let it to be a backlog
https://github.com/atlanhq/atlas-metastore/actions/runs/8890490131
Check how difficult it is to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically dependency review is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially, I tried with the latest version for Java 8 supported https://central.sonatype.com/artifact/org.hibernate.validator/hibernate-validator/6.2.5.Final
This is not working as the repository/gorupId got changed from org.hibernate
to org.hibernate.validator
which is why the validator is not working (possible issue might be due to conflict in dependency).
I have limited knowledge of how dependency works in Java. If you can help debug further, I am happy to jump on an call and solve this.
Change description
Type of change
Related issues
Checklists
Development
Security
Code review