Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ-22: Data contract PreProcessor #2937

Merged
merged 25 commits into from
Apr 30, 2024
Merged

DQ-22: Data contract PreProcessor #2937

merged 25 commits into from
Apr 30, 2024

Conversation

bichitra95
Copy link
Collaborator

@bichitra95 bichitra95 commented Apr 22, 2024 •
edited

Change description

This Code change will handle the creation and updation of DataContract typedef.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Feature #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bichitra95 bichitra95 changed the title Data contract PreProcessor DG-22: Data contract PreProcessor Apr 24, 2024
nikhilbonte21
nikhilbonte21 requested changes Apr 26, 2024
View reviewed changes
addons/policies/bootstrap_entity_policies.json Outdated Show resolved Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
@nikhilbonte21 nikhilbonte21 changed the title DG-22: Data contract PreProcessor DQ-22: Data contract PreProcessor Apr 27, 2024
@bichitra95
Merge create and update AuthPolicy for DataContract
8ed00b3
@bichitra95
Update DataContract attributes from public to private and create gett…
5434342 
…er for needed attributes
@bichitra95
Add setter for private attributes and formatted the file
09c500a
@bichitra95
Address PR review changes
d78cdc1 
* Remove version util and moved getCurrentVersion method to preprocessor
* Remove unused varibles
* Optimize fetching latest version of contract
*
nikhilbonte21
nikhilbonte21 requested changes Apr 29, 2024
View reviewed changes
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
nikhilbonte21
nikhilbonte21 requested changes Apr 29, 2024
View reviewed changes
...ache/atlas/repository/store/graph/v2/preprocessor/contract/AbstractContractPreProcessor.java Outdated Show resolved Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Show resolved Hide resolved
...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved
@bichitra95
Address code review comments
9779ffe 
    * Remove purgebyId call and remove skip auth in the purge method
    * Make DataContract attributes public for serialisation and deserialisation of JSON
    * Make minor changes for optimisation
nikhilbonte21
nikhilbonte21 previously approved these changes Apr 30, 2024
View reviewed changes
sumandas0
sumandas0 reviewed Apr 30, 2024
View reviewed changes
repository/pom.xml Outdated
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
<version>4.3.0.Final</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a CVE of severity medium here! please fix it. Can't let it to be a backlog
image
https://github.com/atlanhq/atlas-metastore/actions/runs/8890490131

Check how difficult it is to fix it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically dependency review is failing

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Just bump it to 4.3.2 and we will be fine here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHSA-845h-985r-jrqh

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I tried with the latest version for Java 8 supported https://central.sonatype.com/artifact/org.hibernate.validator/hibernate-validator/6.2.5.Final

This is not working as the repository/gorupId got changed from org.hibernate to org.hibernate.validator which is why the validator is not working (possible issue might be due to conflict in dependency).

I have limited knowledge of how dependency works in Java. If you can help debug further, I am happy to jump on an call and solve this.

@bichitra95 bichitra95 merged commit 7a3a1c5 into master Apr 30, 2024
4 checks passed
@bichitra95 bichitra95 deleted the data-contract branch April 30, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumandas0 sumandas0 sumandas0 approved these changes

@nikhilbonte21 nikhilbonte21 nikhilbonte21 left review comments

@mehtaanshul mehtaanshul Awaiting requested review from mehtaanshul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bichitra95 @sumandas0 @nikhilbonte21