From 323e65114ab323ec7888a4a9735f97f0345438a3 Mon Sep 17 00:00:00 2001
From: Gerson Sunye <sunye@atlanmod.org>
Date: Mon, 13 Jun 2022 16:39:45 +0200
Subject: [PATCH] Reduce the size of neoemf-data-hbase generated artifact

To correctly test the neoemf-data-hbase module inside the neoemf-tests module, we had to use test-scope dependencies as compile-scope ones. As a result, the generated jar was too big, i.e. > 130MB.
Now we generated a test-jar that includes all test dependencies and import it to the neoemf-tests module.
---
 neoemf-data/hbase/pom.xml                     | 56 +++++++++++++++----
 .../assembly/test-jar-with-dependencies.xml   | 23 ++++++++
 neoemf-tests/pom.xml                          | 10 ++++
 pom.xml                                       |  5 ++
 4 files changed, 84 insertions(+), 10 deletions(-)
 create mode 100644 neoemf-data/hbase/src/main/assembly/test-jar-with-dependencies.xml

diff --git a/neoemf-data/hbase/pom.xml b/neoemf-data/hbase/pom.xml
index 3bec45caa..6d9b2166f 100644
--- a/neoemf-data/hbase/pom.xml
+++ b/neoemf-data/hbase/pom.xml
@@ -18,13 +18,6 @@
 
     <properties>
         <hbase.version>2.4.12</hbase.version>
-        <!--
-        HBase MiniCluster fails to launch if hadopp.version >= 3.1.0
-
-        java.lang.IncompatibleClassChangeError:
-            Found interface org.apache.hadoop.hdfs.protocol.HdfsFileStatus, but class was expected
-        -->
-        <hadoop.version>3.3.3</hadoop.version><!-- Follow HBase dependencies -->
     </properties>
 
     <dependencies>
@@ -32,6 +25,11 @@
             <groupId>org.apache.hbase</groupId>
             <artifactId>hbase-testing-util</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.hbase</groupId>
+            <artifactId>hbase-testing-util</artifactId>
+            <type>test-jar</type>
+        </dependency>
         <dependency>
             <groupId>org.apache.hbase</groupId>
             <artifactId>hbase-client</artifactId>
@@ -47,15 +45,26 @@
             <dependency>
                 <groupId>org.apache.hbase</groupId>
                 <artifactId>hbase-testing-util</artifactId>
-                <scope>compile</scope>
+                <scope>test</scope>
                 <version>${hbase.version}</version>
                 <exclusions>
                     <exclusion>
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-log4j12</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-reload4j</artifactId>
+                    </exclusion>
                 </exclusions>
             </dependency>
+            <dependency>
+                <groupId>org.apache.hbase</groupId>
+                <artifactId>hbase-testing-util</artifactId>
+                <scope>test</scope>
+                <type>test-jar</type>
+                <version>${hbase.version}</version>
+            </dependency>
             <dependency>
                 <groupId>org.apache.hbase</groupId>
                 <artifactId>hbase-client</artifactId>
@@ -64,7 +73,7 @@
             <dependency>
                 <groupId>org.junit.vintage</groupId>
                 <artifactId>junit-vintage-engine</artifactId>
-                <version>5.8.2</version>
+                <version>${junit.version}</version>
                 <scope>test</scope>
             </dependency>
         </dependencies>
@@ -89,7 +98,34 @@
                     </instructions>
                 </configuration>
             </plugin>
-
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>test-jar</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-assembly-plugin</artifactId>
+                <configuration>
+                    <descriptors>
+                        <descriptor>src/main/assembly/test-jar-with-dependencies.xml</descriptor>
+                    </descriptors>
+                </configuration>
+                <executions>
+                    <execution>
+                        <phase>package</phase>
+                        <goals>
+                            <goal>single</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 
diff --git a/neoemf-data/hbase/src/main/assembly/test-jar-with-dependencies.xml b/neoemf-data/hbase/src/main/assembly/test-jar-with-dependencies.xml
new file mode 100644
index 000000000..5723487f1
--- /dev/null
+++ b/neoemf-data/hbase/src/main/assembly/test-jar-with-dependencies.xml
@@ -0,0 +1,23 @@
+<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
+          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+          xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
+    <id>test-jar-with-dependencies</id>
+    <formats>
+        <format>jar</format>
+    </formats>
+    <includeBaseDirectory>false</includeBaseDirectory>
+    <dependencySets>
+        <dependencySet>
+            <outputDirectory>/</outputDirectory>
+            <useProjectArtifact>true</useProjectArtifact>
+            <useProjectAttachments>true</useProjectAttachments>
+            <unpack>false</unpack>
+            <scope>test</scope>
+            <includes>
+                <include>*:test-jar:*</include>
+                <include>*:jar:*</include>
+                <include>${project.groupId}:${project.artifactId}:test-jar</include>
+            </includes>
+        </dependencySet>
+    </dependencySets>
+</assembly>
diff --git a/neoemf-tests/pom.xml b/neoemf-tests/pom.xml
index 90d1d4637..520bde55c 100644
--- a/neoemf-tests/pom.xml
+++ b/neoemf-tests/pom.xml
@@ -229,6 +229,16 @@
             <scope>test</scope>
         </dependency>
 
+        <!-- I don't know why, some classes are not included into neoemf-data-hbase test-jar -->
+        <!-- This dependency is needed to correctly test the HBase backend-->
+        <dependency>
+            <groupId>org.apache.hbase</groupId>
+            <artifactId>hbase-testing-util</artifactId>
+            <type>test-jar</type>
+            <version>${hbase.version}</version>
+            <scope>test</scope>
+        </dependency>
+
     </dependencies>
 
 </project>
diff --git a/pom.xml b/pom.xml
index 8eccc79f8..28b35781a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -490,6 +490,11 @@
                     <artifactId>maven-gpg-plugin</artifactId>
                     <version>1.6</version>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-assembly-plugin</artifactId>
+                    <version>3.3.0</version>
+                </plugin>
             </plugins>
         </pluginManagement>
     </build>