Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal server error when attempting to delete topology referenced in scenario #135

Closed
SethFalco opened this issue Mar 10, 2023 · 0 comments · Fixed by #145
Closed

Internal server error when attempting to delete topology referenced in scenario #135

SethFalco opened this issue Mar 10, 2023 · 0 comments · Fixed by #145
Labels
area/web Changes related to OpenDC web components kind/bug Something isn't working

Comments

@SethFalco
Copy link

SethFalco commented Mar 10, 2023 •
edited

Steps to reproduce

  1. Create a topology
  2. Create a portfolio
  3. Select your new portfolio
  4. Create a new scenario, in the modal that appears, specify the topology from step 1
  5. Navigate back to project details
  6. Attempt to delete your topology

Expected

A warning that it cannot be deleted because it's referenced in a portfolio/scenario, and that either the scenario must be deleted first. (Or the entire portfolio the scenario is in.)

In the network tab I should something more like a 400 (bad request) or 403 (forbidden).

Actual

Nothing happens in the UI, but in Network tab I can see a 500, internal server error.

image
@SethFalco SethFalco changed the title Internal server error when attempting to delete topology references in portfolio Internal server error when attempting to delete topology referenced in scenario Mar 10, 2023
@fabianishere fabianishere added kind/bug Something isn't working area/web Changes related to OpenDC web components labels Mar 10, 2023
fabianishere added a commit that referenced this issue Mar 26, 2023
@fabianishere
bug(web): Inform user when deleted topology is still used
a9da766 
This change fixes #135 which showed that trying to delete a topology
used by a scenario would result in nothing happening in the UI and a 500
error being returned by the server. We check whether a scenario still
references the topology and show an error to the user if that happens.

Fixes #135
@fabianishere fabianishere mentioned this issue Mar 27, 2023
Merged
fabianishere added a commit that referenced this issue Mar 30, 2023
@fabianishere
merge: Address issues with web UI (#145)
0db9d47 
This pull request addresses several issues that have been reported for the OpenDC web UI.

## Implementation Notes ⚒️

* Update dependencies for web UI
* Inform user when deleted topology is still used
* Do not offset hover layer after dragging
* Fix access to machines on lower shelves 
* Do not allow selection of empty unit
* Fix rack deletion

Fixes #135, #136, #137, #138, #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/web Changes related to OpenDC web components kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address issues with web UI atlarge-research/opendc
2 participants
@fabianishere @SethFalco