New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: function to bookmark current-url #118

Merged
merged 1 commit into from Aug 23, 2018

Conversation

3 participants
@watkinsr
Contributor

watkinsr commented Aug 23, 2018

Would be nice to bookmark the current URL I think.

@jmercouris

This comment has been minimized.

Show comment
Hide comment
@jmercouris

jmercouris Aug 23, 2018

Collaborator

Hi, thank you very much for your interest!

Your function is nice and clean, but I believe that it has the same functionality as:

‘’’bookmark-current-page’’’

so perhaps instead clean up bookmark-current-page and implement it in the same way, or make an alias or something, I’m not sure.

Collaborator

jmercouris commented Aug 23, 2018

Hi, thank you very much for your interest!

Your function is nice and clean, but I believe that it has the same functionality as:

‘’’bookmark-current-page’’’

so perhaps instead clean up bookmark-current-page and implement it in the same way, or make an alias or something, I’m not sure.

@watkinsr

This comment has been minimized.

Show comment
Hide comment
@watkinsr

watkinsr Aug 23, 2018

Contributor

@jmercouris as far as I could tell and manually test. "BOOKMARK-CURRENT-PAGE" will only bookmark the buffer name. It does not get the latest URL so if you happened to navigate away from the initially entered URL, it would bookmark the first entry. Hence, the need for this function.

Alternatively, I could refactor "BOOKMARK-CURRENT-PAGE" to this function definition?

Contributor

watkinsr commented Aug 23, 2018

@jmercouris as far as I could tell and manually test. "BOOKMARK-CURRENT-PAGE" will only bookmark the buffer name. It does not get the latest URL so if you happened to navigate away from the initially entered URL, it would bookmark the first entry. Hence, the need for this function.

Alternatively, I could refactor "BOOKMARK-CURRENT-PAGE" to this function definition?

@jmercouris

This comment has been minimized.

Show comment
Hide comment
@jmercouris

jmercouris Aug 23, 2018

Collaborator

Ah, I understand now, my apologies! Thank you for the clarification!!!

Collaborator

jmercouris commented Aug 23, 2018

Ah, I understand now, my apologies! Thank you for the clarification!!!

@jmercouris jmercouris merged commit ccc289b into atlas-engineer:master Aug 23, 2018

@watkinsr

This comment has been minimized.

Show comment
Hide comment
@watkinsr

watkinsr Aug 23, 2018

Contributor

That's my first ever OSS PR by the way, glad to help! I know it's rather trivial. Hopefully I can do more!

Contributor

watkinsr commented Aug 23, 2018

That's my first ever OSS PR by the way, glad to help! I know it's rather trivial. Hopefully I can do more!

@jmercouris

This comment has been minimized.

Show comment
Hide comment
@jmercouris

jmercouris Aug 23, 2018

Collaborator

Congratulations! to the first of hopefully many more :)

if you need tasks, I have a huge list :D

Collaborator

jmercouris commented Aug 23, 2018

Congratulations! to the first of hopefully many more :)

if you need tasks, I have a huge list :D

@watkinsr

This comment has been minimized.

Show comment
Hide comment
@watkinsr

watkinsr Aug 24, 2018

Contributor

@jmercouris Could you send the list through to ryanwatkins54@gmail.com ? 👍

Contributor

watkinsr commented Aug 24, 2018

@jmercouris Could you send the list through to ryanwatkins54@gmail.com ? 👍

@Ambrevar

This comment has been minimized.

Show comment
Hide comment
@Ambrevar

Ambrevar Aug 24, 2018

Contributor

Better: could you publish it in the repo?
An Org file would be great! :)

Contributor

Ambrevar commented Aug 24, 2018

Better: could you publish it in the repo?
An Org file would be great! :)

@jmercouris

This comment has been minimized.

Show comment
Hide comment
@jmercouris

jmercouris Aug 24, 2018

Collaborator
Collaborator

jmercouris commented Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment