Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jump-heading: clean headings, specially for Wikipedia #287

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@vindarel
Copy link
Member

commented Aug 2, 2019

Wikipedia headings end with "[edit]", in french it's an even longer
"[modifier | modifier le code]". That's ugly.
We strip what comes after the first bracket.

for #155

We need a list of real candidates and a list of user-friendly names, hence the elegant use of a closure. I found no built-in mechanism for this in read-from-minibuffer

@Ambrevar
Copy link
Member

left a comment

Try implementing this with object-string, see if this is elegant enough.

source/jump-heading.lisp Outdated Show resolved Hide resolved
source/jump-heading.lisp Outdated Show resolved Hide resolved
source/jump-heading.lisp Outdated Show resolved Hide resolved
source/jump-heading.lisp Outdated Show resolved Hide resolved
@vindarel

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

It's much better indeed with object-string.

jump-heading: clean headings, specially for Wikipedia
Wikipedia headings end with "[edit]", in french an even longer
"[modifier | modifier le code]". That's ugly.
We strip what comes after the first bracket.

for #155

@Ambrevar Ambrevar force-pushed the vindarel/clean-heading branch from 7e3b5be to 6b42718 Aug 2, 2019

@vindarel vindarel merged commit a8db69a into master Aug 2, 2019

@vindarel vindarel deleted the vindarel/clean-heading branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.