From 603629b27e8f5e17cd04cd6a3c759ebb35b5de0d Mon Sep 17 00:00:00 2001 From: Mikhail Mazurskiy Date: Thu, 28 Mar 2019 20:24:25 +1100 Subject: [PATCH 1/2] Add missing dependencies for golangci-lint --- golangcilint/def.bzl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/golangcilint/def.bzl b/golangcilint/def.bzl index 32a3c91..ca38cd0 100644 --- a/golangcilint/def.bzl +++ b/golangcilint/def.bzl @@ -27,6 +27,8 @@ def _golangcilint_impl(ctx): transitive_depsets = [ depset(sdk.srcs), depset(sdk.tools), + depset(sdk.libs), + depset([sdk.go]), ] default_runfiles = ctx.attr._golangcilint[DefaultInfo].default_runfiles if default_runfiles != None: From 864fde1c98ab943cf8bc61768bff5473d1277068 Mon Sep 17 00:00:00 2001 From: Mikhail Mazurskiy Date: Thu, 28 Mar 2019 20:30:30 +1100 Subject: [PATCH 2/2] Run buildifier --- golangcilint/deps.bzl | 16 ++++++++-------- gometalinter/deps.bzl | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/golangcilint/deps.bzl b/golangcilint/deps.bzl index 48fb086..b29b979 100644 --- a/golangcilint/deps.bzl +++ b/golangcilint/deps.bzl @@ -10,12 +10,12 @@ _PREFIX = ( _VERSION = "1.14.0" _CHECKSUMS = { - "windows-386": "d819336b57a61c2676fb99352fead8aa567b454202e22670eec5833b04eb3a78", - "windows-amd64": "e79cbe016591832b85ce66f29c8180ebd8a45dcb793a44c9d3ff101bd7f3fe76", - "darwin-386": "af352896aa6fa9d830a2b1f2fa0f5655d66372138ce5975c44fca4e4bdd85de1", - "linux-amd64": "4b7495539c84ecfb4256f1e7c8bcc9aea6732aef7360fd43ff239cea05d566c1", - "linux-386": "af93eb9d4722830940e74e6c018154c8182b31dd3ab5599fc7a3cdcdd472b37e", - "darwin-amd64": "9906ff1eb2cc01e53ba31f44a937300633b1f52ad227d9e206506c6c1b083a29", + "windows-386": "d819336b57a61c2676fb99352fead8aa567b454202e22670eec5833b04eb3a78", + "windows-amd64": "e79cbe016591832b85ce66f29c8180ebd8a45dcb793a44c9d3ff101bd7f3fe76", + "darwin-386": "af352896aa6fa9d830a2b1f2fa0f5655d66372138ce5975c44fca4e4bdd85de1", + "linux-amd64": "4b7495539c84ecfb4256f1e7c8bcc9aea6732aef7360fd43ff239cea05d566c1", + "linux-386": "af93eb9d4722830940e74e6c018154c8182b31dd3ab5599fc7a3cdcdd472b37e", + "darwin-amd64": "9906ff1eb2cc01e53ba31f44a937300633b1f52ad227d9e206506c6c1b083a29", } def _golangcilint_download_impl(ctx): @@ -29,8 +29,8 @@ def _golangcilint_download_impl(ctx): if arch not in _CHECKSUMS: fail("Unsupported arch {}".format(arch)) - url = _DOWNLOAD_URI.format(version=_VERSION, arch=arch) - prefix = _PREFIX.format(version=_VERSION, arch=arch) + url = _DOWNLOAD_URI.format(version = _VERSION, arch = arch) + prefix = _PREFIX.format(version = _VERSION, arch = arch) sha256 = _CHECKSUMS[arch] ctx.template( diff --git a/gometalinter/deps.bzl b/gometalinter/deps.bzl index 79b885e..0bbb731 100644 --- a/gometalinter/deps.bzl +++ b/gometalinter/deps.bzl @@ -4,12 +4,12 @@ _GOMETALINTER_TARBALLS = { "darwin_amd64": ( "gometalinter-2.0.10-darwin-amd64.tar.gz", "gometalinter-2.0.10-darwin-amd64", - "b21c28a236f05d1cd1a394240388afdc3a20a2ddfeb34acb19c651d5d1936523" + "b21c28a236f05d1cd1a394240388afdc3a20a2ddfeb34acb19c651d5d1936523", ), "linux_amd64": ( "gometalinter-2.0.10-linux-amd64.tar.gz", "gometalinter-2.0.10-linux-amd64", - "111f656a8599349168544b9ae0dbc93240edcb28a81a92e9810ceaa40575545a" + "111f656a8599349168544b9ae0dbc93240edcb28a81a92e9810ceaa40575545a", ), }