This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Handle SIGTERM error when the process already finished #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooray! All contributors have signed the CLA. |
mskonovalov
commented
Sep 30, 2020
| @@ -81,6 +81,10 @@ func (p *process) run(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func isFinished(err error) bool { | |||
| return err.Error() == "os: process already finished" | |||
There was a problem hiding this comment.
correct me if I'm wrong but it doesn't seem to be any better way because the instance of the error that got returned is package private unfortunately :(
mskonovalov
force-pushed
the
sigterm-debug
branch
from
e8e287b
to
d602f48
Compare
ash2k
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for part 1 of #113