Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider copy edits to CSV error messages #665

Closed
noah-schechter opened this issue Jun 1, 2023 · 3 comments
Closed

Consider copy edits to CSV error messages #665

noah-schechter opened this issue Jun 1, 2023 · 3 comments

Comments

@noah-schechter
Copy link
Collaborator

noah-schechter commented Jun 1, 2023

[Not a deploy-blocker] Right now, the error message for blank-but-required attributes looks like this:
Screenshot 2023-06-01 at 3 44 23 PM

I think we should make sure we match the formatting of the attribute names in the documentation, meaning we would change attr_description to description by 1) adding a badge and 2) removing the "attr_" prefix.

For example, the updated message would like:

  • Row 1
    description: can't be blank.
    sensitive: can't be blank.
    status: can't be blank.

Longer term, we can add more friendly messages, but for now I just want to make sure the attribute naming system matches what the system expects.

@noah-schechter
Copy link
Collaborator Author

For example, later on we should fix present our own error message for internal errors like this one:

Escape sequence started on line 338: [User-inputted text] Comments: did not terminate. Parsing will continue on line 339. Escape sequences are allowed to span up to 10 lines. This threshold avoids collecting the whole file into memory when an escape sequence does not terminate. You can change it using the escape_max_lines option: https://hexdocs.pm/csv/CSV.html#decode/2

@milesmcc
Copy link
Collaborator

milesmcc commented Jun 2, 2023

image

@noah-schechter
Copy link
Collaborator Author

This looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants