You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Not a deploy-blocker] Right now, the error message for blank-but-required attributes looks like this:
I think we should make sure we match the formatting of the attribute names in the documentation, meaning we would change attr_description to description by 1) adding a badge and 2) removing the "attr_" prefix.
For example, the updated message would like:
Row 1 description: can't be blank. sensitive: can't be blank. status: can't be blank.
Longer term, we can add more friendly messages, but for now I just want to make sure the attribute naming system matches what the system expects.
The text was updated successfully, but these errors were encountered:
For example, later on we should fix present our own error message for internal errors like this one:
Escape sequence started on line 338: [User-inputted text] Comments: did not terminate. Parsing will continue on line 339. Escape sequences are allowed to span up to 10 lines. This threshold avoids collecting the whole file into memory when an escape sequence does not terminate. You can change it using the escape_max_lines option: https://hexdocs.pm/csv/CSV.html#decode/2
[Not a deploy-blocker] Right now, the error message for blank-but-required attributes looks like this:
![Screenshot 2023-06-01 at 3 44 23 PM](https://private-user-images.githubusercontent.com/100018299/242709185-4af1d410-2da7-4d3e-9c8c-c48d7ce6f7bc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwNjQ2NDQsIm5iZiI6MTcyNTA2NDM0NCwicGF0aCI6Ii8xMDAwMTgyOTkvMjQyNzA5MTg1LTRhZjFkNDEwLTJkYTctNGQzZS05YzhjLWM0OGQ3Y2U2ZjdiYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODMxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgzMVQwMDMyMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZjgxYTQ5ZjdhM2FlNTBlOGFhZTFiODIyMTlhZTBjMzRhZDhiZjJmOTJlODVlZDBmOWFlM2E1YzFlMGQ3YTQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.kVScHRZCAoH0Cnpy14xCUUjx8HzI2de58r6RossyHps)
I think we should make sure we match the formatting of the attribute names in the documentation, meaning we would change attr_description to
description
by 1) adding a badge and 2) removing the "attr_" prefix.For example, the updated message would like:
description
: can't be blank.sensitive
: can't be blank.status
: can't be blank.Longer term, we can add more friendly messages, but for now I just want to make sure the attribute naming system matches what the system expects.
The text was updated successfully, but these errors were encountered: