Enable to delete a product #36

UwicyezaG · 2024-06-25T15:03:03Z

Description

The seller should be able to delete a specific item in their collection such that they can remove items they no longer deal in or were erroneously added. This functionality ensures that sellers can manage their product listings effectively and maintain an accurate inventory.

Definition of Done:

Sellers can see and use the delete option for each item in their inventory.
Deletion requires seller confirmation to proceed.
Successfully deleted items display a confirmation message.
Canceled deletions do not alter the inventory.
Errors, such as attempting to delete a non-existent item or encountering deletion failures, are appropriately managed and communicated to the seller.

Screenshots

netlify · 2024-06-25T15:03:17Z

✅ Deploy Preview for knights-fecommerce ready!

Name	Link
🔨 Latest commit	`aac9a68`
🔍 Latest deploy log	https://app.netlify.com/sites/knights-fecommerce/deploys/6687de58f08a640008e0470c
😎 Deploy Preview	https://deploy-preview-36--knights-fecommerce.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-06-25T15:03:31Z

✅ Deploy Preview for knight-fe ready!

Name	Link
🔨 Latest commit	`aac9a68`
🔍 Latest deploy log	https://app.netlify.com/sites/knight-fe/deploys/6687de584856df0008d7bed8
😎 Deploy Preview	https://deploy-preview-36--knight-fe.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls · 2024-06-25T15:06:00Z

coverage: 86.803%. remained the same
when pulling da05ef4 on ft-delete-product
into 911c279 on develop.

faid-terence

@UwicyezaG
Please rebase with develop and resolve the conflicts
And increase the test coverage !!

coveralls · 2024-07-01T14:24:41Z

coverage: 85.767% (-2.0%) from 87.757%
when pulling cc73f9f on ft-delete-product
into 523bb6d on develop.

coveralls · 2024-07-03T14:57:02Z

coverage: 87.403% (-0.4%) from 87.754%
when pulling ef9883d on ft-delete-product
into 86a5319 on develop.

coveralls · 2024-07-03T20:22:32Z

coverage: 87.439% (-0.3%) from 87.754%
when pulling 3547f19 on ft-delete-product
into 86a5319 on develop.

coveralls · 2024-07-03T20:22:32Z

coverage: 87.403% (-0.4%) from 87.754%
when pulling 3547f19 on ft-delete-product
into 86a5319 on develop.

coveralls · 2024-07-03T21:22:07Z

coverage: 88.221% (+0.5%) from 87.754%
when pulling b9d81f6 on ft-delete-product
into 86a5319 on develop.

aimedivin · 2024-07-04T20:47:04Z

src/Routes/Router.tsx

-  const isAdmin = decodedToken?.role.toLowerCase() === 'admin';
-  const isVendor = decodedToken?.role.toLowerCase() === 'vendor';
-  const isBuyer = decodedToken?.role.toLowerCase() === 'buyer';
+  const isAdmin = decodedToken?.userType.toLowerCase() === 'admin';


@UwicyezaG You must use the value from 'role' instead of 'userType', as the token does not contain userType.

faid-terence · 2024-07-05T06:28:50Z

src/components/Products/DashboardSingleProduct/DashboardSingleProduct.tsx

@UwicyezaG Are we using userType or role ?

faid-terence · 2024-07-05T06:29:46Z

@UwicyezaG
Work on the change requests and rebase with develop to resolve the conflicts

coveralls · 2024-07-05T10:25:18Z

coverage: 87.599% (-0.4%) from 87.967%
when pulling f51257f on ft-delete-product
into b6fa239 on develop.

coveralls · 2024-07-05T10:33:56Z

coverage: 87.599% (-0.4%) from 87.967%
when pulling a919981 on ft-delete-product
into b6fa239 on develop.

coveralls · 2024-07-05T11:54:38Z

coverage: 88.069% (+0.1%) from 87.967%
when pulling aac9a68 on ft-delete-product
into b6fa239 on develop.

faid-terence

PR Approved @UwicyezaG !

Enable to delete a product

UwicyezaG added frontend Related to frontend in progress task has already been started labels Jun 25, 2024

UwicyezaG requested review from maxCastro1, elijahladdie, MC-Knight, aimedivin, GSinseswa721 and Ndevu12 June 27, 2024 13:01

UwicyezaG added Ready for reviews and removed frontend Related to frontend in progress task has already been started labels Jun 27, 2024

UwicyezaG requested a review from faid-terence June 27, 2024 13:05

MC-Knight approved these changes Jun 27, 2024

View reviewed changes

UwicyezaG force-pushed the ft-delete-product branch from da05ef4 to 89e1075 Compare June 27, 2024 20:34

This comment was marked as resolved.

Sign in to view

faid-terence self-requested a review June 30, 2024 19:24

faid-terence requested changes Jun 30, 2024

View reviewed changes

faid-terence assigned UwicyezaG Jun 30, 2024

faid-terence added this to the Auth and Product Management milestone Jun 30, 2024

faid-terence linked an issue Jun 30, 2024 that may be closed by this pull request

A seller should be able to delete a specific item #21

Closed

faid-terence added the Highest Priority label Jun 30, 2024

UwicyezaG force-pushed the ft-delete-product branch 2 times, most recently from 999ac7d to cc73f9f Compare July 1, 2024 14:22

UwicyezaG force-pushed the ft-delete-product branch 3 times, most recently from b1ef24b to 6304a35 Compare July 2, 2024 12:15

UwicyezaG force-pushed the ft-delete-product branch 2 times, most recently from 6c25367 to 3547f19 Compare July 3, 2024 20:19

UwicyezaG force-pushed the ft-delete-product branch 2 times, most recently from 64da819 to b9d81f6 Compare July 3, 2024 21:19

maxCastro1 approved these changes Jul 4, 2024

View reviewed changes

Ndevu12 approved these changes Jul 4, 2024

View reviewed changes

aimedivin requested changes Jul 4, 2024

View reviewed changes

faid-terence requested changes Jul 5, 2024

View reviewed changes

src/components/Products/DashboardSingleProduct/DashboardSingleProduct.tsx Outdated

Copy link

Collaborator

faid-terence Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UwicyezaG Are we using userType or role ?

UwicyezaG force-pushed the ft-delete-product branch from b9d81f6 to f51257f Compare July 5, 2024 10:22

UwicyezaG force-pushed the ft-delete-product branch 2 times, most recently from 4dddc9f to a919981 Compare July 5, 2024 10:31

Enable to delete a product

aac9a68

UwicyezaG force-pushed the ft-delete-product branch from a919981 to aac9a68 Compare July 5, 2024 11:51

GSinseswa721 approved these changes Jul 5, 2024

View reviewed changes

elijahladdie approved these changes Jul 6, 2024

View reviewed changes

faid-terence approved these changes Jul 6, 2024

View reviewed changes

faid-terence merged commit e5468d2 into develop Jul 6, 2024
15 checks passed

Calebgisa72 pushed a commit that referenced this pull request Jul 6, 2024

Merge pull request #36 from atlp-rwanda/ft-delete-product

c510169

Enable to delete a product

Calebgisa72 pushed a commit that referenced this pull request Jul 6, 2024

Merge pull request #36 from atlp-rwanda/ft-delete-product

8f36613

Enable to delete a product

Calebgisa72 pushed a commit that referenced this pull request Jul 6, 2024

Merge pull request #36 from atlp-rwanda/ft-delete-product

802af9d

Enable to delete a product

Calebgisa72 pushed a commit that referenced this pull request Jul 6, 2024

Merge pull request #36 from atlp-rwanda/ft-delete-product

b8a24d5

Enable to delete a product

Calebgisa72 pushed a commit that referenced this pull request Jul 8, 2024

Merge pull request #36 from atlp-rwanda/ft-delete-product

d350c67

Enable to delete a product

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable to delete a product #36

Enable to delete a product #36

UwicyezaG commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

coveralls commented Jun 25, 2024

This comment was marked as resolved.

faid-terence left a comment

coveralls commented Jul 1, 2024

coveralls commented Jul 3, 2024

coveralls commented Jul 3, 2024

coveralls commented Jul 3, 2024

coveralls commented Jul 3, 2024

aimedivin Jul 4, 2024

faid-terence Jul 5, 2024

faid-terence commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

faid-terence left a comment

Enable to delete a product #36

Enable to delete a product #36

Conversation

UwicyezaG commented Jun 25, 2024 • edited Loading

Description

Definition of Done:

Screenshots

netlify bot commented Jun 25, 2024 • edited Loading

✅ Deploy Preview for knights-fecommerce ready!

netlify bot commented Jun 25, 2024 • edited Loading

✅ Deploy Preview for knight-fe ready!

coveralls commented Jun 25, 2024

This comment was marked as resolved.

faid-terence left a comment

Choose a reason for hiding this comment

coveralls commented Jul 1, 2024

coveralls commented Jul 3, 2024

coveralls commented Jul 3, 2024

coveralls commented Jul 3, 2024

coveralls commented Jul 3, 2024

aimedivin Jul 4, 2024

Choose a reason for hiding this comment

faid-terence Jul 5, 2024

Choose a reason for hiding this comment

faid-terence commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

faid-terence left a comment

Choose a reason for hiding this comment

UwicyezaG commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading