New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups/chmod gitignore #2

Merged
merged 4 commits into from Feb 22, 2017

Conversation

Projects
None yet
2 participants
@Quix0r
Copy link
Contributor

Quix0r commented Feb 22, 2017

This PR ignores all torrent files as they should never be committed and also libs/db.php as it contains sensitive infomations. This also fixes CHMOD. Only scripts that should be run from shell must have execute flag set, all others not. The server does not execute PHP scripts, it only reads them.

Quix0r added some commits Feb 22, 2017

Cleanups:
- libs/db.php should not be committed and being ignored by GIT as this file may
  contain sensitive informations
- fixed chmod, no execute rights on these files is needed (only for shell
  scripts)
- deleted torrent file and ignored all others as they should not be included in any commits

Signed-off-by: Roland Haeder <roland@mxchange.org>
no error reporting is a bad idea
Signed-off-by: Roland Haeder <roland@mxchange.org>
@Quix0r

This comment has been minimized.

Copy link
Contributor Author

Quix0r commented Feb 22, 2017

The 2nd commit removes my added error_reporting(0); commands again as your script issues many E_NOTICE. Please fix them all: error_reporting(E_ALL | E_STRICT); is generally only for development environments 0 for productive servers.

@Quix0r

This comment has been minimized.

Copy link
Contributor Author

Quix0r commented Feb 22, 2017

And yeah, my changes remove external references as it is generally not a good idea to have them around.

Quix0r added some commits Feb 22, 2017

killed many white-spaces + added css and font file
Signed-off-by: Roland Haeder <roland@mxchange.org>
Continued:
- added missing JavaScript files (don't reference them from external resource as
  if the external website has only one security problem and trojan horses will
  spread over their files, they will spread everywhere. If you keep files local,
  they won't spread so far.
- needed change due to removed db.php file (which contains sensitive infomations
  that should never be committed)

Signed-off-by: Roland Haeder <roland@mxchange.org>
@atmoner

This comment has been minimized.

Copy link
Owner

atmoner commented Feb 22, 2017

@Quix0r Thank you for your work! I will test all this when I go home and if it works without error I would validate the push

@atmoner

This comment has been minimized.

Copy link
Owner

atmoner commented Feb 22, 2017

@Quix0r I am not against the modification of the check of the install! But the user should be warned to create a db.php file (in install.php).
And thanks for the missing javascript file!

@atmoner atmoner merged commit 107eeb2 into atmoner:master Feb 22, 2017

@atmoner atmoner self-requested a review Feb 22, 2017

@Quix0r

This comment has been minimized.

Copy link
Contributor Author

Quix0r commented Feb 23, 2017

Okay, then better mention that change in readme file.

@Quix0r

This comment has been minimized.

Copy link
Contributor Author

Quix0r commented Feb 23, 2017

Should I add it or do you add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment