From 814ae2e339b93f343b8783998e56e467a8240e65 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Fri, 2 Jan 2015 12:02:29 -0700 Subject: [PATCH] Emit a deprecation warning when accessing deprecated views via $::view --- package.json | 2 +- src/space-pen.coffee | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 96c61fa..d007920 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "grunt-atomdoc": "^1.0.0" }, "dependencies": { - "grim": "^0.12.0", + "grim": "^0.13.0", "underscore-plus": "1.x" } } diff --git a/src/space-pen.coffee b/src/space-pen.coffee index 9ea08bb..96ade71 100644 --- a/src/space-pen.coffee +++ b/src/space-pen.coffee @@ -282,7 +282,11 @@ class Builder # jQuery extensions $.fn.view = -> - @[0]?.spacePenView + if element = @[0] + if element.__spacePenView? + viewConstructorName = element.__spacePenView.constructor.name + Grim?.deprecate("Accessing `#{viewConstructorName}` via `$::view()` is deprecated. Use the raw DOM node or underlying model object instead.") + element.spacePenView $.fn.views = -> @toArray().map (elt) -> $elt = $(elt)