Skip to content

fix: update uuid to v8 #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2020
Merged

fix: update uuid to v8 #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446e4bc
fix: update uuid to v8
aminya Dec 29, 2020
83507b8
chore: enable semantic release [skip ci]
aminya Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,30 +51,31 @@ jobs:
- name: Lint ✨
run: npm run lint

# Release:
# needs: [Test, Lint]
# if: github.ref == 'refs/heads/master' &&
# github.event.repository.fork == false
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - uses: UziTech/action-setup-atom@v1
# - uses: actions/setup-node@v1
# with:
# node-version: "12.x"
# - name: NPM install
# run: npm install
# - name: Build and Commit
# run: npm run build-commit
# # NOTE: uncomment when ready
# # - name: Release 🎉
# # uses: cycjimmy/semantic-release-action@v2
# # with:
# # extends: |
# # @semantic-release/apm-config
# # env:
# # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# # ATOM_ACCESS_TOKEN: ${{ secrets.ATOM_ACCESS_TOKEN }}
Release:
needs: [Test, Lint]
if: github.ref == 'refs/heads/master' &&
github.event.repository.fork == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: UziTech/action-setup-atom@v1
- uses: actions/setup-node@v1
with:
node-version: "12.x"
- name: NPM install
run: npm install

# - name: Build and Commit
# run: npm run build-commit

- name: Release 🎉
uses: cycjimmy/semantic-release-action@v2
with:
extends: |
@semantic-release/apm-config
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ATOM_ACCESS_TOKEN: ${{ secrets.ATOM_ACCESS_TOKEN }}

Skip:
if: contains(github.event.head_commit.message, '[skip ci]')
Expand Down
4 changes: 2 additions & 2 deletions lib/grammar-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os from 'os';
import fs from 'fs';
import path from 'path';
import uuid from 'uuid';
import { v1 as uuidv1 } from 'uuid';

// Public: GrammarUtils - utilities for determining how to run code
export default {
Expand All @@ -21,7 +21,7 @@ export default {
fs.mkdirSync(this.tempFilesDir);
}

const tempFilePath = this.tempFilesDir + path.sep + uuid.v1() + extension;
const tempFilePath = this.tempFilesDir + path.sep + uuidv1() + extension;

const file = fs.openSync(tempFilePath, 'w');
fs.writeSync(file, code);
Expand Down
4 changes: 2 additions & 2 deletions lib/grammar-utils/d.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os from 'os';
import fs from 'fs';
import path from 'path';
import uuid from 'uuid';
import { v1 as uuidv1 } from 'uuid';

// Public: GrammarUtils.D - a module which assist the creation of D temporary files
export default {
Expand All @@ -19,7 +19,7 @@ export default {
try {
if (!fs.existsSync(this.tempFilesDir)) { fs.mkdirSync(this.tempFilesDir); }

const tempFilePath = `${this.tempFilesDir + path.sep}m${uuid.v1().split('-').join('_')}.d`;
const tempFilePath = `${this.tempFilesDir + path.sep}m${uuidv1().split('-').join('_')}.d`;

const file = fs.openSync(tempFilePath, 'w');
fs.writeSync(file, code);
Expand Down
4 changes: 2 additions & 2 deletions lib/grammar-utils/matlab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os from 'os';
import fs from 'fs';
import path from 'path';
import uuid from 'uuid';
import { v1 as uuidv1 } from 'uuid';

// Public: GrammarUtils.MATLAB - a module which assist the creation of MATLAB temporary files
export default {
Expand All @@ -19,7 +19,7 @@ export default {
try {
if (!fs.existsSync(this.tempFilesDir)) { fs.mkdirSync(this.tempFilesDir); }

const tempFilePath = `${this.tempFilesDir + path.sep}m${uuid.v1().split('-').join('_')}.m`;
const tempFilePath = `${this.tempFilesDir + path.sep}m${uuidv1().split('-').join('_')}.m`;

const file = fs.openSync(tempFilePath, 'w');
fs.writeSync(file, code);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"babel-preset-env": "^1.6.0",
"strip-ansi": "^3.0.0",
"underscore": "^1.8.3",
"uuid": "^3.0.1"
"uuid": "^8.3.2"
},
"optionalDependencies": {
"babel-cli": "^6.26.0",
Expand Down