Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automated dependency bumps for the Nightly Release pipeline #40

Closed
wants to merge 4 commits into from

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Jul 11, 2020

Requirements for Adding, Changing, or Removing a Feature (from template)

Requirements for Adding, Changing, or Removing a Feature

Issue or RFC Endorsed by Atom's Maintainers

None.

Description of the Change

Disables automated dependency bumps in the Nightly Release pipeline config.

This is a feature implemented upstream: atom#20999

It opens a large number of Pull Requests that seem genuinely helpful to upstream, but which we are likely to have to ignore and/or close. We can re-enable this some time in the future if need be.

Allows us to run the Nightly Release pipeline without creating large numbers of dependency update PRs at this repo (or somehow accidentally at upstream).

Alternate Designs

Comment out with YAML # comments (?)

Maybe there is a way to do this in Azure DevOps UI instead? I'm not sure if you can, so I went with this, because it does disable the job.

Possible Drawbacks

None. I don't think we are interested in reviewing or merging these dependency bump PRs at this time.

Verification Process

CI run shows a "canceled" icon next to the "Bump Dependencies" job on the Nightly Release pipeline.

https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=124&view=results

Release Notes

N/A

Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little skeptical about this. I prefer to get those pull requests here so we can try them! I actually installed the dependent bot. Once we get our releases running, I want to try bumping deps! LEss of an issue, but this PR also will cause some not much necessary conflict with upstream.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Jul 11, 2020

Alright!

Given my intent is to match CI to what we want it to do, and we want it to open those PRs... then this can be closed! Fine by me!

Useful for manual runs of the Nightly pipeline though when you want to debug code/the pipeline together... maybe this job should be set to not run if the reason for the run is "manual"? Just a thought.

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#build-variables

Build.Reason

@aminya
Copy link
Member

aminya commented Jul 11, 2020

Thank you anyways.

@aminya aminya closed this Jul 11, 2020
@aminya aminya added the CI label Jul 11, 2020
@aminya aminya added this to In progress in Build, bootstrap, CI via automation Jul 11, 2020
@aminya aminya moved this from In progress to Done in Build, bootstrap, CI Jul 11, 2020
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Jul 11, 2020

See comment above. Might it make sense to disable this if the Buld.Reason is "manual" i.e. manually running this pipeline doesn't cause a bunch of PRs? Or... maybe we can handle it anyhow. I assume it doesn't open duplicate PRs, so after the first time the effect might not be so bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants