Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Add toggleable tab min-width#298

Merged
silvestreh merged 2 commits intoatom-material:masterfrom
supremebeing7:master
Jul 25, 2016
Merged

Add toggleable tab min-width#298
silvestreh merged 2 commits intoatom-material:masterfrom
supremebeing7:master

Conversation

@supremebeing7
Copy link
Copy Markdown

This provides a toggleable solution to #229.

@supremebeing7
Copy link
Copy Markdown
Author

I added specs for this as well, although the new specs as well as about 10 other specs (including all of the others in settings-tabs-spec.js) were failing for me locally, and I didn't have time to do a deep dive to find out what's going on.

I assume, at least for those tests in settings-tabs-spec.js, that the failure is in the setup, so fixing one will fix them all.

@silvestreh
Copy link
Copy Markdown
Member

Unfortunately, like I mentioned in another (unrelated) issue, I won't be able to check this out for a while as my computer is dead and I can't buy a new one. I'll sure try to check it out as soon as possible.

@supremebeing7
Copy link
Copy Markdown
Author

No problem. Thanks for the heads up!

@silvestreh
Copy link
Copy Markdown
Member

I'm not a fan of removing the max-width property from tabs. I can see the benefit of removing the min-width as it would remove the necessity for scrolling the tab bar. If you can update your PR I'll merge it. Thanks!

@supremebeing7
Copy link
Copy Markdown
Author

Even though the max-width is toggleable and _not_ removed by default?

I can definitely update the PR, though I'll just have to keep using my forked copy unfortunately because I have been really enjoying having no max-width.

@silvestreh silvestreh merged commit 82f2e2c into atom-material:master Jul 25, 2016
@silvestreh
Copy link
Copy Markdown
Member

👍 thanks!

@silvestreh silvestreh changed the title Add toggleable tab min- and max-width Add toggleable tab min-width Jul 25, 2016
@silvestreh
Copy link
Copy Markdown
Member

@supremebeing7, I forgot to mention… run this command git update-index --assume-unchanged styles/custom.less to avoid changing the custom.less file in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants