Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggleable tab min-width #298

Merged
merged 2 commits into from Jul 25, 2016

Conversation

@supremebeing7
Copy link

commented Jun 8, 2016

This provides a toggleable solution to #229.

@supremebeing7

This comment has been minimized.

Copy link
Author

commented Jun 8, 2016

I added specs for this as well, although the new specs as well as about 10 other specs (including all of the others in settings-tabs-spec.js) were failing for me locally, and I didn't have time to do a deep dive to find out what's going on.

I assume, at least for those tests in settings-tabs-spec.js, that the failure is in the setup, so fixing one will fix them all.

@silvestreh

This comment has been minimized.

Copy link
Member

commented Jun 8, 2016

Unfortunately, like I mentioned in another (unrelated) issue, I won't be able to check this out for a while as my computer is dead and I can't buy a new one. I'll sure try to check it out as soon as possible.

@supremebeing7

This comment has been minimized.

Copy link
Author

commented Jun 9, 2016

No problem. Thanks for the heads up!

@silvestreh

This comment has been minimized.

Copy link
Member

commented Jul 9, 2016

I'm not a fan of removing the max-width property from tabs. I can see the benefit of removing the min-width as it would remove the necessity for scrolling the tab bar. If you can update your PR I'll merge it. Thanks!

@supremebeing7

This comment has been minimized.

Copy link
Author

commented Jul 12, 2016

Even though the max-width is toggleable and _not_ removed by default?

I can definitely update the PR, though I'll just have to keep using my forked copy unfortunately because I have been really enjoying having no max-width.

@supremebeing7 supremebeing7 force-pushed the supremebeing7:master branch from 544dbc8 to 8b05d49 Jul 12, 2016
@silvestreh silvestreh merged commit 82f2e2c into atom-material:master Jul 25, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@silvestreh

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

👍 thanks!

@silvestreh silvestreh changed the title Add toggleable tab min- and max-width Add toggleable tab min-width Jul 25, 2016
@silvestreh

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

@supremebeing7, I forgot to mention… run this command git update-index --assume-unchanged styles/custom.less to avoid changing the custom.less file in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.