From 95c421c12e35787d9f9073bfead4216994c2ecc0 Mon Sep 17 00:00:00 2001 From: fundon Date: Fri, 11 Apr 2014 02:05:06 +0800 Subject: [PATCH 1/7] unsubscribe scrollView events Signed-off-by: fundon --- lib/minimap-view.coffee | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/minimap-view.coffee b/lib/minimap-view.coffee index 60940ea3..4c4128d3 100644 --- a/lib/minimap-view.coffee +++ b/lib/minimap-view.coffee @@ -94,6 +94,7 @@ class MinimapView extends View unsubscribeFromEditor: -> @unsubscribe @editor, '.minimap' + @unsubscribe @scrollView, '.minimap' subscribeToEditor: -> @subscribe @editor, 'screen-lines-changed.minimap', @updateMinimapEditorView From 1ff608d00771b17e259780c6bd302a3c324ab3a9 Mon Sep 17 00:00:00 2001 From: fundon Date: Fri, 11 Apr 2014 18:49:17 +0800 Subject: [PATCH 2/7] update comments --- lib/minimap-indicator.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/minimap-indicator.coffee b/lib/minimap-indicator.coffee index bf777062..9c45c34b 100644 --- a/lib/minimap-indicator.coffee +++ b/lib/minimap-indicator.coffee @@ -6,11 +6,13 @@ # | |----------> Minimap Wrapper # | | . # | | . -# #########------> Minimap Indicator (Minimap visible area) +# #########------> Minimap Indicator # | | . # --------- . # . . # ............. +# + # # Basic Rectangle # @@ -120,4 +122,3 @@ class Indicator extends Rectangle computeFromCenterY: (cy) -> @setCenterY(cy) - @scroller.y - From 5d041d4140b93b7b37abc841fb78536ea46b5543 Mon Sep 17 00:00:00 2001 From: fundon Date: Fri, 11 Apr 2014 18:50:18 +0800 Subject: [PATCH 3/7] update comments --- lib/minimap-indicator.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/minimap-indicator.coffee b/lib/minimap-indicator.coffee index 9c45c34b..9997831f 100644 --- a/lib/minimap-indicator.coffee +++ b/lib/minimap-indicator.coffee @@ -6,7 +6,7 @@ # | |----------> Minimap Wrapper # | | . # | | . -# #########------> Minimap Indicator +# =========------> Minimap Indicator # | | . # --------- . # . . From 1b3d92499bfc0f0f9771c636b184fef894d8dea8 Mon Sep 17 00:00:00 2001 From: fundon Date: Sat, 12 Apr 2014 16:53:04 +0800 Subject: [PATCH 4/7] remove unnecessary minimapScroll variable --- lib/minimap-view.coffee | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/minimap-view.coffee b/lib/minimap-view.coffee index 4c4128d3..e4f29143 100644 --- a/lib/minimap-view.coffee +++ b/lib/minimap-view.coffee @@ -30,7 +30,6 @@ class MinimapView extends View @scaleY = @scaleX * 0.8 @minimapScale = @scale(@scaleX, @scaleY) @miniScrollView = @miniEditorView.scrollView - @minimapScroll = 0 @transform @miniWrapper[0], @minimapScale # dragging's status @isPressed = false From 213f2200b70aff212b95a0ad103682f26a3ae8e0 Mon Sep 17 00:00:00 2001 From: fundon Date: Sun, 13 Apr 2014 04:05:52 +0800 Subject: [PATCH 5/7] force to check scrollView and editor variables, #59 --- lib/minimap-view.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/minimap-view.coffee b/lib/minimap-view.coffee index e4f29143..4b93f938 100644 --- a/lib/minimap-view.coffee +++ b/lib/minimap-view.coffee @@ -92,8 +92,8 @@ class MinimapView extends View @subscribeToEditor() unsubscribeFromEditor: -> - @unsubscribe @editor, '.minimap' - @unsubscribe @scrollView, '.minimap' + @unsubscribe @editor, '.minimap' if @editor? + @unsubscribe @scrollView, '.minimap' if @scrollView? subscribeToEditor: -> @subscribe @editor, 'screen-lines-changed.minimap', @updateMinimapEditorView From 1bed024cacfb201597aecf505975c1d8353be88e Mon Sep 17 00:00:00 2001 From: fundon Date: Sun, 13 Apr 2014 04:09:53 +0800 Subject: [PATCH 6/7] Release 0.9.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 285c9d33..80fec807 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "minimap", "main": "./lib/minimap", - "version": "0.9.0", + "version": "0.9.1", "private": true, "description": "A preview of the full source code.", "author": "Fangdun Cai ", From af9f3c2103a2018354fff3f88963e74741ec621a Mon Sep 17 00:00:00 2001 From: fundon Date: Sun, 13 Apr 2014 04:11:22 +0800 Subject: [PATCH 7/7] update history --- History.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/History.md b/History.md index 135804e9..a26da7f0 100644 --- a/History.md +++ b/History.md @@ -1,3 +1,8 @@ +0.9.1 / 2014-04-13 +================== + +* fix minimap doesn't update on active view changes when auto-toggle is true, #59 + 0.9.0 / 2014-04-11 ==================