This repository has been archived by the owner. It is now read-only.

Remove usage of Babel #77

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented May 1, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Removes usage of Babel and JSX, instead preferring vanilla JavaScript where possible. This prevents unnecessary transpilation of source files and also cuts down on the file size a little bit.

Alternate Designs

None.

Benefits

In non-Etch-related files, all Babel offers is import syntax. Those can easily be converted to the old require syntax.
In Etch files, etch.dom is used instead of JSX.
These changes prevent unnecessary transpilation of files.

Possible Drawbacks

None.

Applicable Issues

None.

50Wliu added some commits May 1, 2018

@50Wliu 50Wliu merged commit 38938e0 into master May 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-babel branch May 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.