Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding Additional Information to About Page #81
Description of the Change
I've added the information provided via
The about page already provides the Atom version, I simply use the process.versions helper to get the Electron and Chrome versions, and the process.version to get the Node version.
These are shown by clicking a
Edit by @rsese to drop in before/after screenshots
I at first just had the new version numbers shown by default directly below the Atom version, in the same font size, and this looked cluttered and busy. I decided since it was extra info and only useful to a subset of people, I'd put it behind a
This change will give people the ability to quickly view the current versions of Electron, Chrome and Node being used in their build of Atom without having to open a terminal, and is more discoverable than a terminal command.
I haven't noticed any drawbacks in my testing, and no changes in performance of the About page when opening or reloading. It doesn't hide any existing info or add steps to get to existing info, so those who don't need / want the additional version numbers provided won't notice a difference.
referenced this pull request
Jun 23, 2018
Thanks for contributing @trevorrl
The pull request template only needs to be filled out here as you've done above, we shouldn't edit the actual pull request template file (that's what shown for anyone that opens a new pull request). Can you remove those changes to
Also, can you share before and after screenshots?
Once that's done, though we can't make any promises about the pull request being accepted, I'll ask the team to take a look.
Let me know what you think!
Edit 2: It actually wasn't an issue with the specs, just extra semicolons. Fixed!