Setting ATOM_NODE_VERSION to 0.16.0 breaks installing packages using node-pre-gyp #189

Closed
suda opened this Issue Sep 12, 2014 · 3 comments

Projects

None yet

3 participants

@suda
suda commented Sep 12, 2014

Commit 4d5dcda changes default ATOM_NODE_VERSION to 0.16.0 which breaks installing packages using node-pre-gyp like serialport:

node-pre-gyp ERR! install error 
node-pre-gyp ERR! stack Error: Unsupported target version: 0.16.0
node-pre-gyp ERR! stack     at get_node_abi (/Users/travis/build/x/y/node_modules/serialport/node_modules/node-pre-gyp/lib/util/versioning.js:27:19)
node-pre-gyp ERR! stack     at Object.module.exports.evaluate (/Users/travis/build/x/y/node_modules/serialport/node_modules/node-pre-gyp/lib/util/versioning.js:133:21)
node-pre-gyp ERR! stack     at install (/Users/travis/build/x/y/node_modules/serialport/node_modules/node-pre-gyp/lib/install.js:134:35)
node-pre-gyp ERR! stack     at Object.self.commands.(anonymous function) [as install] (/Users/travis/build/x/y/node_modules/serialport/node_modules/node-pre-gyp/lib/node-pre-gyp.js:48:37)
node-pre-gyp ERR! stack     at run (/Users/travis/build/x/y/node_modules/serialport/node_modules/node-pre-gyp/bin/node-pre-gyp:77:30)
node-pre-gyp ERR! stack     at Object.<anonymous> (/Users/travis/build/x/y/node_modules/serialport/node_modules/node-pre-gyp/bin/node-pre-gyp:130:1)
node-pre-gyp ERR! stack     at Module._compile (module.js:456:26)
node-pre-gyp ERR! stack     at Object.Module._extensions..js (module.js:474:10)
node-pre-gyp ERR! stack     at Module.load (module.js:356:32)
node-pre-gyp ERR! stack     at Function.Module._load (module.js:312:12)
node-pre-gyp ERR! System Darwin 13.2.0
node-pre-gyp ERR! command "node" "/Users/travis/build/x/y/node_modules/serialport/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/travis/build/x/y/node_modules/serialport
node-pre-gyp ERR! node -v v0.10.30
node-pre-gyp ERR! node-pre-gyp -v v0.5.19
node-pre-gyp ERR! not ok 
npm ERR! serialport@1.4.6 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1

Manually setting it to 0.10.22 which is used in TravisCI build script because node-v0.10.22.tar.gz isn't available on Atom's CDN: https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist/v0.10.22/node-v0.10.22.tar.gz

@kevinsawicki kevinsawicki added the bug label Sep 12, 2014
@zcbenz zcbenz was assigned by kevinsawicki Sep 12, 2014
@kevinsawicki
Member

@zcbenz Is this something that can be supported?

@zcbenz
Member
zcbenz commented Sep 16, 2014

It would require patching node-pre-gyp to be supported, like adding atom-shell as a new runtime like how node-webkit was supported. There was also a discussion of node-pre-gyp in atom-shell: electron/electron#533.

@suda suda referenced this issue in mapbox/node-pre-gyp Sep 16, 2014
Closed

Add atom-shell as runtime #110

@zcbenz
Member
zcbenz commented Oct 20, 2014

This is being worked on in node-pre-gyp at mapbox/node-pre-gyp#112.

@zcbenz zcbenz closed this Oct 20, 2014
@voodootikigod voodootikigod referenced this issue in EmergingTechnologyAdvisors/node-serialport Jun 25, 2015
Closed

Tracking Electron support #538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment