New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul ArchiveView and remove atom-space-pen-views #45

Merged
merged 5 commits into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
@as-cii
Member

as-cii commented Feb 17, 2017

This pull request is a substantial rewrite of almost the whole package. Every file that was previously using jQuery has now been converted to JavaScript and its dependency on atom-space-pen-views has been removed too. I also believe the logic for jumping between files via the keyboard shortcuts has been greatly simplified as it doesn't rely on the DOM anymore.

Feature-wise nothing should have changed, but this is another step toward removing jQuery from Atom.

/cc: @ungb

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Feb 24, 2017

Contributor

@as-cii The ArchiveEditor class should define an onDidDestroy handler for any packages that subscribe to closing pane-items. It's really the only subscription method worth keeping for parity with ordinary TextEditor instances... a package or theme might subscribe to a pane-item's close event via a tab's .item property.

Which is how it made its presence known in File-Icons' spec-suite.

Contributor

Alhadis commented Feb 24, 2017

@as-cii The ArchiveEditor class should define an onDidDestroy handler for any packages that subscribe to closing pane-items. It's really the only subscription method worth keeping for parity with ordinary TextEditor instances... a package or theme might subscribe to a pane-item's close event via a tab's .item property.

Which is how it made its presence known in File-Icons' spec-suite.

Alhadis added a commit to file-icons/atom that referenced this pull request Feb 26, 2017

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Mar 2, 2017

LGTM!

Tested the following file formats:
.epub
.jar
.love
.nupkg
.tar.gz
.war
.zip
.whl
.xpi

ungb commented Mar 2, 2017

LGTM!

Tested the following file formats:
.epub
.jar
.love
.nupkg
.tar.gz
.war
.zip
.whl
.xpi

@as-cii as-cii merged commit 2f9686d into master Mar 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@as-cii as-cii deleted the as-remove-jquery branch Mar 3, 2017

Alhadis added a commit to file-icons/atom that referenced this pull request Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment