New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async timing issue in tests #63

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
1 participant
@jasonrudolph
Member

jasonrudolph commented May 7, 2018

Prior to this change, spec/archive-editor-spec.js made use of async operations, but it didn't use the requisite async spec helpers. This led to flaky test failures like the one seen in https://circleci.com/gh/atom/atom/7468.

@jasonrudolph jasonrudolph merged commit 7a61336 into master May 7, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jasonrudolph jasonrudolph deleted the fix-test-failures-when-running-atom-with-electron-2.0 branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment