New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Atom on 32bit Ubuntu 14.04 results in 64bit binary #12972

Closed
hotice opened this Issue Oct 13, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@hotice

hotice commented Oct 13, 2016

Prerequisites

  • Can you reproduce the problem in safe mode?

Not applicable.

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.

Description

Trying to build the latest Atom 1.11.1 in Ubuntu 14.04 32bit results in a 64bit binary being created:

andrei@andrei-desktop:~/atom-1.11.1/out/atom-1.11.1-i386$ readelf -a -W atom | grep Class: | sort | uniq
  Class:                             ELF64

As you can see, even the atom executable path has "i386" in its name, but the executable is for 64bit. The machine is 32bit:

$ uname -a
Linux andrei-desktop 3.13.0-24-generic #46-Ubuntu SMP Thu Apr 10 19:08:14 UTC 2014 i686 i686 i686 GNU/Linux

And:

$  node -e "console.log(process.arch)" 
ia32

The previous Atom version I was able to build properly on 32bit was 1.10.2 (I didn't try 1.11.0 or 1.12 beta).

Here is the build log: http://pastebin.com/raw/WgywYX72

Steps to Reproduce

  1. Using Ubuntu 14.04 32bit, install nodejs v6 from its official Ubuntu/Debian repository. I was also able to reproduce this with nodejs v4 from the its official repository and npm v3 installed manually (installing the nodejs v4 package provides npm v2, and Atom 1.11.1 refuses to build with npm older than v3; this was not the case for Atom 1.10.2).
  2. Download Atom 1.11.1 and build it with script/build

Expected behavior: Atom should be built for 32bit.
Actual behavior: Atom is built for 64bit.

Versions

Tested on two Ubuntu 14.04 32bit machines. Atom version: 1.11.1 (latest stable).

I'm not sure if these are required in this case but anyway:

$ atom --version
Atom    : 1.10.2
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0
$ apm --version
apm  1.12.5
npm  3.10.5
node 4.4.5
python 2.7.6
git 1.9.1
@50Wliu

This comment has been minimized.

Member

50Wliu commented Oct 13, 2016

@nathansobo Possibly a problem with the new build scripts? 1.10 was the last version that worked and also the last version with the old build scripts.

@nathansobo

This comment has been minimized.

Contributor

nathansobo commented Oct 13, 2016

Possibly. I can't spend time on this right now but if someone wants to investigate I will look at a PR.

@Ben3eeE Ben3eeE added the help-wanted label Oct 13, 2016

flububb added a commit to flububb/atom that referenced this issue Oct 16, 2016

Pick the right architecture on linux atom#12972
I don't know if the fixation of the architecture on non linux platforms makes any sense (line 25). Maybe simply 'arch': process.arch is the right way to go. Can't test it on my linux machine.

flububb added a commit to flububb/atom that referenced this issue Oct 16, 2016

Merge pull request #1 from flububb/flububb-fix-12972
Pick the right architecture on linux atom#12972
@i-svr

This comment has been minimized.

i-svr commented Oct 27, 2016

logs.txt
I can confirm the issue. It is impossible to build Atom 1.11.2 from sources on Slackware x32-bit.
Also, this error in Atom's installation scripts was present in Atom's 1.10.2 sources, but i didn't bother to report (decided to install 1.10.0 version using sbopkg instead).

During compilation from sources process, i noticed a string in console:
Downloading electron-v0.37.8-linux-x64.zip

But I'm using x32-bit operating system!
There is an error in installation scripts.

PS: logs attached.

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Oct 28, 2016

@i-svr If you want you can test the PR that fixes this issue #13001

@hotice

This comment has been minimized.

hotice commented Oct 28, 2016

That fixes it for me on Ubuntu 32bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment