New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.0-beta2: Cursor stucks at the first letter when using macOS Chinese IME #14911

Closed
weihanglo opened this Issue Jun 28, 2017 · 32 comments

Comments

Projects
None yet
@weihanglo

weihanglo commented Jun 28, 2017

Prerequisites

Description

Cursor stuck at the first letter when using macOS built-in Chinese pinyin IME.

We expect to input some characters first, and choose a word in IME panel. But from 1.19.0 (maybe beta 1), the cursor always stucks at the first letter. Although I can still type Chinese correctly under the circumstances., it is more helpful to see what you are typing out.

Steps to Reproduce

Expected behavior:

In 1.18.0, it looks well.

atom

Actual behavior:

However, the cursor moves no more in 1.19.0-beta2.

atom-beta

Reproduces how often: every time

Versions

OS: macOS Sierra 10.12.5
Atom : 1.19.0-beta2
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0

Additional Information

At first, I dived into source code to search for the problem. Soon, I overwhelmed with the large codebase of Atom. I cannot figure out which commit producing this bug. If anyone can point out which part may produce this problem, I can help to solve it. Thanks :)

@weihanglo weihanglo changed the title from 1.19.0-beta2: Cursor stuck at the first letter when using macOS Chinese IME to 1.19.0-beta2: Cursor stucks at the first letter when using macOS Chinese IME Jun 28, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Jun 30, 2017

Contributor

I'm guessing this is also related to the TextEditorComponent rewrite.

/cc @as-cii @nathansobo Did the rewrite change how IME was handled?

Contributor

maxbrunsfeld commented Jun 30, 2017

I'm guessing this is also related to the TextEditorComponent rewrite.

/cc @as-cii @nathansobo Did the rewrite change how IME was handled?

@ykpythemind

This comment has been minimized.

Show comment
Hide comment
@ykpythemind

ykpythemind Jul 3, 2017

Similar problem occurs when using Google IME (Japanese)

Cursor stuck at the first letter, and I can see one letter when I'm typing.

  • Mac OS Sierra 10.12.5
  • Atom 1.19.0-beta2
  • Google 日本語入力 2.20.2700.1

ykpythemind commented Jul 3, 2017

Similar problem occurs when using Google IME (Japanese)

Cursor stuck at the first letter, and I can see one letter when I'm typing.

  • Mac OS Sierra 10.12.5
  • Atom 1.19.0-beta2
  • Google 日本語入力 2.20.2700.1
@as-cii

This comment has been minimized.

Show comment
Hide comment
@as-cii

as-cii Jul 20, 2017

Member

It looks like this is a bug in Electron 1.6, but it should be fixed in Electron 1.7 (which is still in beta, though). Backporting a fix to 1.6 seems to be non-trivial, so I am afraid we will have to wait till Electron 1.7 hits stable in order to use it in Atom.

Meanwhile Electron 1.7 is in beta, though, it might be nice to get the ball rolling on the upgrade. Simply bumping the Electron version makes Atom crash so we'll need dedicate some time to figure out why. /cc: @iolsen for prioritization.

Member

as-cii commented Jul 20, 2017

It looks like this is a bug in Electron 1.6, but it should be fixed in Electron 1.7 (which is still in beta, though). Backporting a fix to 1.6 seems to be non-trivial, so I am afraid we will have to wait till Electron 1.7 hits stable in order to use it in Atom.

Meanwhile Electron 1.7 is in beta, though, it might be nice to get the ball rolling on the upgrade. Simply bumping the Electron version makes Atom crash so we'll need dedicate some time to figure out why. /cc: @iolsen for prioritization.

@ethancfchen

This comment has been minimized.

Show comment
Hide comment
@ethancfchen

ethancfchen Aug 9, 2017

I'm using Mac Zhuyin IME, it's the same problem:
8 -09-2017 10-15-08
(I typed: 5j/ [space] jp6gj [space] bj4 [enter])

By the way I'm using Atom 1.19.0 now.

ethancfchen commented Aug 9, 2017

I'm using Mac Zhuyin IME, it's the same problem:
8 -09-2017 10-15-08
(I typed: 5j/ [space] jp6gj [space] bj4 [enter])

By the way I'm using Atom 1.19.0 now.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Aug 9, 2017

Contributor

Anyone impacted by this on 1.19 should downgrade to 1.18 and disable updates until Electron 1.7 gets out of beta and we can upgrade. My apologies.

Contributor

nathansobo commented Aug 9, 2017

Anyone impacted by this on 1.19 should downgrade to 1.18 and disable updates until Electron 1.7 gets out of beta and we can upgrade. My apologies.

@50Wliu 50Wliu added electron and removed needs-reproduction labels Aug 9, 2017

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Aug 9, 2017

The problem also occurs in v1.19.0 which was released as a stable version.

My environment:

  • Atom 1.19.0 x64
  • macOS Sierra 10.12.6
  • Google Japanese IME

It is regrettable that the problem reported in the beta version was not fixed and the stable version was released as it was.

It will be fixed by downgrading, but it will be difficult for general users who are not developers.

But, everyone has a mistake.

Based on this, if you are going to improve Atom, it would be nice to be able to easily downgrade.

akabekobeko commented Aug 9, 2017

The problem also occurs in v1.19.0 which was released as a stable version.

My environment:

  • Atom 1.19.0 x64
  • macOS Sierra 10.12.6
  • Google Japanese IME

It is regrettable that the problem reported in the beta version was not fixed and the stable version was released as it was.

It will be fixed by downgrading, but it will be difficult for general users who are not developers.

But, everyone has a mistake.

Based on this, if you are going to improve Atom, it would be nice to be able to easily downgrade.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Aug 9, 2017

Contributor

It is regrettable that the problem reported in the beta version was not fixed and the stable version was released as it was.

Yeah, unfortunately my understanding is that there was no way to really fix this without upgrading Electron, and the new version isn't ready. It should be pretty easy to downgrade to 1.18 by downloading it from the releases page. You can disable updates from the about dialog. I'm sorry to roll this to stable with this issue. Maybe we should have waited, but there were many improvements that we needed to get out there.

Contributor

nathansobo commented Aug 9, 2017

It is regrettable that the problem reported in the beta version was not fixed and the stable version was released as it was.

Yeah, unfortunately my understanding is that there was no way to really fix this without upgrading Electron, and the new version isn't ready. It should be pretty easy to downgrade to 1.18 by downloading it from the releases page. You can disable updates from the about dialog. I'm sorry to roll this to stable with this issue. Maybe we should have waited, but there were many improvements that we needed to get out there.

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Aug 10, 2017

It is possible to obtain an old version from the release page and downgrade it. But, what to choose from downloads is hard to understand.

I am a developer so I can understand what I need. However, many users obtained from https://atom.io/ will have difficulty selecting archives selecting to their environment.

Improvement plan:

  1. Add rollup function to about dialog
  2. Organize downloads on release page (in order of popular platform)
  3. Publish old version to https://atom.io/ (Automatically check user environment like latest version)

However, returning to the old version is a risk. Normally it is preferable not to degrade the latest version.

3 seems to be good in these plans. How about placing older version links after warning text explaining the risk?

akabekobeko commented Aug 10, 2017

It is possible to obtain an old version from the release page and downgrade it. But, what to choose from downloads is hard to understand.

I am a developer so I can understand what I need. However, many users obtained from https://atom.io/ will have difficulty selecting archives selecting to their environment.

Improvement plan:

  1. Add rollup function to about dialog
  2. Organize downloads on release page (in order of popular platform)
  3. Publish old version to https://atom.io/ (Automatically check user environment like latest version)

However, returning to the old version is a risk. Normally it is preferable not to degrade the latest version.

3 seems to be good in these plans. How about placing older version links after warning text explaining the risk?

@Riajyuu

This comment has been minimized.

Show comment
Hide comment
@Riajyuu

Riajyuu Aug 11, 2017

If I understand things correctly, this issue seems affecting all non-english IME.

Riajyuu commented Aug 11, 2017

If I understand things correctly, this issue seems affecting all non-english IME.

@miaulightouch

This comment has been minimized.

Show comment
Hide comment
@miaulightouch

miaulightouch Aug 11, 2017

never thought this bug would impact my daily work.

miaulightouch commented Aug 11, 2017

never thought this bug would impact my daily work.

@pollyduan

This comment has been minimized.

Show comment
Hide comment
@pollyduan

pollyduan Aug 11, 2017

i has downgraded to 1.12 directly

pollyduan commented Aug 11, 2017

i has downgraded to 1.12 directly

@DarkNami

This comment has been minimized.

Show comment
Hide comment
@DarkNami

DarkNami Aug 11, 2017

yes, this issue affecting Microsoft Windows IME (Chinese, Japanese), too.

DarkNami commented Aug 11, 2017

yes, this issue affecting Microsoft Windows IME (Chinese, Japanese), too.

@tos-kamiya

This comment has been minimized.

Show comment
Hide comment
@tos-kamiya

tos-kamiya Aug 11, 2017

This issue is also reproduced on Ubuntu Gnome with a Japanese IME (namely fcitx-mozc). I have downgraded to Atom 1.18.

tos-kamiya commented Aug 11, 2017

This issue is also reproduced on Ubuntu Gnome with a Japanese IME (namely fcitx-mozc). I have downgraded to Atom 1.18.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Aug 11, 2017

Contributor

This was a process failure on our part. I misunderstood the magnitude of the issue when I saw it and it got lost in the shuffle. We really value our CJK users and I apologize. We have a workaround for the Chromium bug in the works via #15265 that should go out as a hotfix early next week so everyone can update.

Contributor

nathansobo commented Aug 11, 2017

This was a process failure on our part. I misunderstood the magnitude of the issue when I saw it and it got lost in the shuffle. We really value our CJK users and I apologize. We have a workaround for the Chromium bug in the works via #15265 that should go out as a hotfix early next week so everyone can update.

@nathansobo nathansobo closed this in #15265 Aug 12, 2017

@Ben3eeE Ben3eeE referenced this issue Aug 13, 2017

Closed

version 1.19, input Chinese is very strange #15281

1 of 1 task complete
@buuug7

This comment has been minimized.

Show comment
Hide comment
@buuug7

buuug7 Aug 13, 2017

in 1.19.0-beta2, this will be fixed?

buuug7 commented Aug 13, 2017

in 1.19.0-beta2, this will be fixed?

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Aug 13, 2017

Member

@buuug7 It will be fixed in the next round of hotfix releases. Atom 1.19.1 and 1.20.0-beta2. They should both be released early next week,

Member

Ben3eeE commented Aug 13, 2017

@buuug7 It will be fixed in the next round of hotfix releases. Atom 1.19.1 and 1.20.0-beta2. They should both be released early next week,

@buuug7

This comment has been minimized.

Show comment
Hide comment
@buuug7

buuug7 Aug 14, 2017

@Ben3eeE i can't wait (-_-

buuug7 commented Aug 14, 2017

@Ben3eeE i can't wait (-_-

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Aug 15, 2017

I checked that the problem was fixed in Atom v1.19.1.
Thank you very much!!!

akabekobeko commented Aug 15, 2017

I checked that the problem was fixed in Atom v1.19.1.
Thank you very much!!!

@ethancfchen

This comment has been minimized.

Show comment
Hide comment
@ethancfchen

ethancfchen Aug 15, 2017

Mac Zhuyin IME fixed on 1.19.1, great job, thanks!

2017-08-15 09 58 03

ethancfchen commented Aug 15, 2017

Mac Zhuyin IME fixed on 1.19.1, great job, thanks!

2017-08-15 09 58 03

@miaulightouch

This comment has been minimized.

Show comment
Hide comment
@miaulightouch

miaulightouch Aug 15, 2017

Thank god it works!

miaulightouch commented Aug 15, 2017

Thank god it works!

@weihanglo

This comment has been minimized.

Show comment
Hide comment
@weihanglo

weihanglo Aug 15, 2017

It works! Thanks a lot!

weihanglo commented Aug 15, 2017

It works! Thanks a lot!

@buuug7

This comment has been minimized.

Show comment
Hide comment
@buuug7

buuug7 Aug 15, 2017

Great job , i removed sublime text from my mac and embrace Atom.

buuug7 commented Aug 15, 2017

Great job , i removed sublime text from my mac and embrace Atom.

@tos-kamiya

This comment has been minimized.

Show comment
Hide comment
@tos-kamiya

tos-kamiya Aug 15, 2017

Thanks! Atom 1.19.1 works fine with a Japanese IME (fcitx-mozc) as far as I've tried it on a clean installation of "ubuntu-ja-17.04-desktop-amd64" on VirtualBox.

tos-kamiya commented Aug 15, 2017

Thanks! Atom 1.19.1 works fine with a Japanese IME (fcitx-mozc) as far as I've tried it on a clean installation of "ubuntu-ja-17.04-desktop-amd64" on VirtualBox.

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Aug 15, 2017

Member

Thanks to everyone for reporting back that it is working now ❤️ and apologies for the issue 🙇

Member

Ben3eeE commented Aug 15, 2017

Thanks to everyone for reporting back that it is working now ❤️ and apologies for the issue 🙇

@xionglun

This comment has been minimized.

Show comment
Hide comment
@xionglun

xionglun Sep 19, 2017

Atom 1.19 works fine, but after upgrade to 1.20.0, this problem occurs again.

I use squirrel and macOS 10.12.6 (Atom version, 1.20.0)

xionglun commented Sep 19, 2017

Atom 1.19 works fine, but after upgrade to 1.20.0, this problem occurs again.

I use squirrel and macOS 10.12.6 (Atom version, 1.20.0)

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Sep 19, 2017

Member

/cc: @ungb @rsese Can you check ☝️ with Atom 1.20?

Member

Ben3eeE commented Sep 19, 2017

/cc: @ungb @rsese Can you check ☝️ with Atom 1.20?

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Sep 19, 2017

Contributor

I'm unable to see this issue in atom 1.20.0.
on 1.20.0
ime

Contributor

ungb commented Sep 19, 2017

I'm unable to see this issue in atom 1.20.0.
on 1.20.0
ime

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Sep 19, 2017

Contributor

Using Squirrel that you linked to, I was unable to repro the issue in Atom 1.20.0. Can you attach image or gif of what you're seeing?

rine

Contributor

ungb commented Sep 19, 2017

Using Squirrel that you linked to, I was unable to repro the issue in Atom 1.20.0. Can you attach image or gif of what you're seeing?

rine

@xionglun

This comment has been minimized.

Show comment
Hide comment
@xionglun

xionglun Sep 20, 2017

@ungb Sorry, my issue is not same as this issue. my fault.
But, it's obvious, the popup jump from top left corner to the bottom of line. It's another issue.
You can compare on different versions.

xionglun commented Sep 20, 2017

@ungb Sorry, my issue is not same as this issue. my fault.
But, it's obvious, the popup jump from top left corner to the bottom of line. It's another issue.
You can compare on different versions.

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Sep 20, 2017

Contributor

ahh I see. Not a problem! Can you create a new issue for it @xionglun? you also should link to this one so it will give context on the issue.

Contributor

ungb commented Sep 20, 2017

ahh I see. Not a problem! Can you create a new issue for it @xionglun? you also should link to this one so it will give context on the issue.

@xionglun

This comment has been minimized.

Show comment
Hide comment
@xionglun

xionglun Sep 20, 2017

@ungb OK, I have created a new issue.

xionglun commented Sep 20, 2017

@ungb OK, I have created a new issue.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Mar 29, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

lock bot commented Mar 29, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked and limited conversation to collaborators Mar 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.