Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline documentation refers to setInvisibles, which doesn't exist #16042

Open
50Wliu opened this issue Oct 31, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@50Wliu
Copy link
Member

commented Oct 31, 2017

atom/src/text-editor.js

Lines 3595 to 3603 in bc061bb

// Returns an {Object} representing the current invisible character
// substitutions for this editor. See {::setInvisibles}.
getInvisibles () {
if (!this.mini && this.showInvisibles && (this.invisibles != null)) {
return this.invisibles
} else {
return {}
}
}

A project-wide search reveals only a single result for setInvisibles, which is the comment itself.

@stale

This comment has been minimized.

Copy link

commented Oct 31, 2018

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. Because the Atom team treats their issues as their backlog, stale issues are closed. If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of Atom
  2. Comment that the issue is still reproducible and include:
    • What version of Atom you reproduced the issue on
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

Issues that are labeled as triaged will not be automatically marked as stale.

@stale stale bot added the stale label Oct 31, 2018

@50Wliu

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

Still an issue. URL updated.

@stale stale bot removed the stale label Oct 31, 2018

@thomasstep

This comment has been minimized.

Copy link

commented Apr 5, 2019

What needs to be done to resolve this?

@50Wliu

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@thomasstep updating the documentation to actually list the expected structure of the returned object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.