New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White-cursor gone in 1.26.0 #17174

Closed
Shu-Wan opened this Issue Apr 19, 2018 · 10 comments

Comments

Projects
None yet
7 participants
@Shu-Wan

Shu-Wan commented Apr 19, 2018

Edit by @rsese to add template info

Prerequisites

Description

As of 1.26, the I-bar cursor is no longer white with a dark syntax theme, the cursor is black.

x-ref: #1654, #8663

Steps to Reproduce

As of 1.26:

  1. atom --safe
  2. Set the syntax theme to One Dark
  3. Observe the I-bar cursor

Expected behavior: [What you expect to happen]

Because of #8663, expect the I-bar cursor to be white.

Actual behavior: [What actually happens]

The I-bar cursor is black.

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

$ atom -v
Atom    : 1.28.0-dev-deeed0667
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0

macOS 10.12.6

Additional Information

No screenshots since the cursor doesn't seem to show up on screenshots? 📷


After updated to 1.26.0, cursor in dark theme becomes black again. It makes very hard to track cursor in the dark mode.

Referencing #8663 and #1654

@rsese

This comment has been minimized.

Member

rsese commented Apr 19, 2018

Thanks for the report - I can confirm that on 1.25.1 on macOS 10.12.6 the I-bar is white in safe mode with One Dark syntax theme but on 1.26.0-beta2, the I-bar is black.

/cc @simurai? 🎨

Also @Shu-Wan, for future issues please fill out the issue template - the information in the template is super helpful for us when triaging issues.

@rsese rsese added the ui label Apr 19, 2018

@halorium

This comment has been minimized.

halorium commented Apr 19, 2018

I am turning off auto updates. Yeah, dark cursor on dark theme is rough. Is there a temporary fix for this?

@Shu-Wan

This comment has been minimized.

Shu-Wan commented Apr 20, 2018

@rsese Thanks for the editing and your quick attention! My bad not filling up the template.

My workaround right now is to switch to a light theme. If you are a die-hard dark theme user, don't update to 1.26.0 now.

@vpiskunov

This comment has been minimized.

vpiskunov commented Apr 20, 2018

Same here observed @ 1.26.0, my eyes are dying 🚨😡

@halorium

This comment has been minimized.

halorium commented Apr 20, 2018

I had to switch to a light theme which also is not ideal but at least I can see the cursor. I also noticed that when I open atom from the terminal, the first time it always opens with the folder side bar not showing. This latest update was buggy.

@vpiskunov

This comment has been minimized.

vpiskunov commented Apr 20, 2018

Temporary fix:

In your .atom/styles.less

Add:

.editor {
  cursor: default;
}
@bsg62

This comment has been minimized.

bsg62 commented Apr 21, 2018

Another temporary solution

If you don't like the default cursor as workaround, you can add the following code to your styles.less:

@ibeam-1x: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=');
@ibeam-2x: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC');

.editor {
  cursor: -webkit-image-set(@ibeam-1x 1x, @ibeam-2x 2x) 5 8, text;
}

It's copied from the original pull request in #8663 and restores the white cursor.

@MohammedEssehemy

This comment has been minimized.

MohammedEssehemy commented Apr 22, 2018

@bsg62 this works. Thanks

@simurai

This comment has been minimized.

Member

simurai commented Apr 24, 2018

Looks like the dppx unit stopped working in a -webkit-image-set.

@bsg62's solution to switch to 1x/2x is now part of PR #17208. 👍

@lock

This comment has been minimized.

lock bot commented Oct 21, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.