Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom 1.30.0-beta0: Error: Cannot find module string_decoder #17765

Closed
lgeiger opened this Issue Jul 31, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@lgeiger
Copy link
Contributor

lgeiger commented Jul 31, 2018

Prerequisites

Description

After updating to Atom 1.30.0-beta0, activation of the Github package fails due to a missing indirect dependency with the following error:

module.js:543 Uncaught (in promise) Error: Cannot find module '../node_modules/string_decoder/index.js'
    at Module._resolveFilename (module.js:543:15)
    at Module._resolveFilename (/Applications/Atom Beta.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (/Applications/Atom Beta.app/Contents/Resources/app/src/module-cache.js:354:58)
    at Module.require (file:///Applications/Atom%20Beta.app/Contents/Resources/app.asar/static/index.js:40:43)
    at require (internal/module.js:11:18)
    at customRequire (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:96:26)
    at get_Decoder (/Applications/Atom Beta.app/Contents/Resources/app/node_modules/split/index.js:12:37)
    at split (/Applications/Atom Beta.app/Contents/Resources/app/node_modules/split/index.js:20:28)
    at /Applications/Atom Beta.app/Contents/Resources/app/node_modules/what-the-status/index.js:37:18
    at new Promise (<anonymous>)
    at parse (/Applications/Atom Beta.app/Contents/Resources/app/node_modules/what-the-status/index.js:16:16)
    at Proxy.getStatusBundle (/Applications/Atom Beta.app/Contents/Resources/app/node_modules/github/lib/git-shell-out-strategy.js:602:58)
    at <anonymous>

Steps to Reproduce

  1. Install Atom 1.30.0-beta0 for macOS
  2. Start Atom in a folder with a git repo
  3. Open the dev tools and observe the above error

Expected behavior: Github package activates properly

Actual behavior: Github package doesn't show current repo status and throws the above error in the dev console

Reproduces how often: 100%

Versions

$ atom-beta --version
Atom    : 1.30.0-beta0
Electron: 2.0.5
Chrome  : 61.0.3163.100
Node    : 8.9.3

Additional Information

I'm posting it here since this is likely a issue with during generation of the snapshot builds.
Related issues #17125, #17481 and #17603

@daviwil daviwil added the regression label Jul 31, 2018

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Jul 31, 2018

Thanks for the report @lgeiger 👍, just noting that I can reproduce on macOS 10.12.6 with 1.30.0-beta0.

@rsese rsese added the triaged label Jul 31, 2018

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jul 31, 2018

Thanks @lgeiger! This issue just doesn't want to go away... We're looking into it!

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Aug 1, 2018

Hey @lgeiger, we just shipped 1.30.0-beta1 which should resolve this issue for you. I'll go ahead and close this issue for now but let us know if you continue to see this error!

@daviwil daviwil closed this Aug 1, 2018

@lgeiger

This comment has been minimized.

Copy link
Contributor Author

lgeiger commented Aug 1, 2018

Thanks for the fast response! Works like a charm 🎉

@lock

This comment has been minimized.

Copy link

lock bot commented Jan 28, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.