Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

data-grammar change causes some keybindings to not work #17820

Closed
1 task done
Ben3eeE opened this issue Aug 10, 2018 · 1 comment
Closed
1 task done

data-grammar change causes some keybindings to not work #17820

Ben3eeE opened this issue Aug 10, 2018 · 1 comment

Comments

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Aug 10, 2018

Prerequisites

Description

With tree-sitter the data-grammar attribute changed so some keybindings don't work.

This change should either be documented in the flight manual or be backwards compatible!

Steps to Reproduce

  1. Open your keymap file
  2. Add the example from the flight manual https://flight-manual.atom.io/behind-atom/sections/keymaps-in-depth/#selectors-and-custom-packages
  3. I modified it slightly to:
"atom-text-editor[data-grammar='source js']":
  'ctrl-alt-g': 'editor:log-cursor-scope'

Expected behavior: The keybinding to work regardless of tree-sitter being enabled or not.

Actual behavior: The keybinding works with text mate grammars but with tree-sitter you need to change it to:

"atom-text-editor[data-grammar='javascript']":
  'ctrl-alt-g': 'editor:log-cursor-scope'

Reproduces how often: 100%

Versions

1.31.0-nightly6

Additional Information

/cc: @queerviolet @maxbrunsfeld

@lock
Copy link

lock bot commented Feb 16, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Feb 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant