Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish remaining work needed to announce Atom Nightly channel #17884

Closed
daviwil opened this issue Aug 20, 2018 · 6 comments

Comments

@daviwil
Copy link
Contributor

commented Aug 20, 2018

This issue tracks the remaining tasks that need to be completed before we can fully announce the Atom Nightly channel for general use:

@rsese rsese referenced this issue Nov 27, 2018
1 of 1 task complete
@rsese

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Should we add #18417 to the list @daviwil?

@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

Here goes some guesstimation about the remaining work that needs to be done for having nightly releases.

My current estimate is ~1.5 weeks of actual work (4 days for the actual tasks and 4 more days to do proper testing/verification of the whole pipeline + fixing potential issues).

This is the actual time that I estimate we need to spend working on it, but since we have external dependencies that we can't easily control, shipping this will probably take longer than 1.5 weeks (due to the time we'll be blocked).

Required work

1. Enable publishing of linux Atom Nightly packages to packagecloud.

Very Small: it can be done in <30min.

2. Tweak the announcement blog post

Small: it can be done in ~1h.

We need to update it with remaining suggestions and update the caveats.

3. Add functionality to the Atom.io landing page PR

Small-Medium: it can be done in half a day.

4. Fix Squirrel.Windows to support upgrading to versions above nightly-9

Medium, but potentially large: I estimate the work to take 1-3 days, but we may need to wait for some time until the fixes propagate to Atom.

There are a few things that need to be done. Some of them don't depend on us:

  • Upgrade Atom's electron-winstaller from v2.6.4 to v3.0.4. This may not be trivial since we're using a 2 year old version. I've created a WIP PR.
  • Wait until Squirrel/Squirrel.Windows#1492 gets merged.
  • Wait until a new version of Squirrel.Windows gets published.
  • Wait until electron-winstaller upgrades to the new version of Squirrel.Windows and a new version is published.
  • Upgrade Atom's electron-winstaller to published version.

Optional work

5. Enable side-by-side Atom channel installs on Windows

Medium: it can take 1-2 days. Most of the work has been already done, only some minor work is required on atom.io (comment), but this will require proper testing.

This is nice to have, but it's not a requisite for unblocking nightly releases.

@rafeca rafeca referenced this issue Jun 17, 2019
5 of 5 tasks complete
@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

Good news everyone! we've been able to solve the 4th point of the required steps (the most complex one) by publishing a custom version of electron-winstaller called @atom/electron-winstaller which contains the fixes made in Squirrel/Squirrel.Windows#1492.

With this, the rest of needed work should be trivial 😄

@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

I've enabled nightlies on Linux, updated and tweaked the blog post PR and the atom.io nightly page PR, with this we're ready to ship nightlies!

Unless somebody thinks it's a bad idea, my current plan is to ship the blog post and the nightly page on atom.io tomorrow June 21st.

@Aerijo

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

The Linux nightlies on Ubuntu through apt seem to conflict with beta

Unpacking atom-nightly (1.40.0-nightly12) over (1.36.0-nightly7) ...
dpkg: error processing archive /var/cache/apt/archives/atom-nightly_1.40.0-nightly12_amd64.deb (--unpack):
 trying to overwrite '/usr/share/polkit-1/actions/atom.policy', which is also in package atom-beta 1.39.0-beta2
Errors were encountered while processing:
 /var/cache/apt/archives/atom-nightly_1.40.0-nightly12_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

I can install and use one or the other, but not both. Stable works regardless.

@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

urggg! 😟 thanks for the heads up @Aerijo !

@as-cii that issue is related to #19412 and will get propagated to stable on the next release.

We should probably have different policy files depending on the release channel, e.g atom-stable.policy, atom-beta.policy and atom-nightly.policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.