New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain CSS classes in syntax tokens cause issues #1800

Closed
kevinsawicki opened this Issue Mar 27, 2014 · 8 comments

Comments

Projects
None yet
4 participants
@kevinsawicki
Member

kevinsawicki commented Mar 27, 2014

Reported in atom/highlights#2

Having a token with a close scope generates a .close class which makes the text render incorrectly since Bootstrap defined a .close class for dialogs.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Mar 27, 2014

Contributor

Looks like this stack overflow answer may be relevant.

Contributor

nathansobo commented Mar 27, 2014

Looks like this stack overflow answer may be relevant.

@kevinsawicki kevinsawicki referenced this issue May 5, 2014

Closed

Open Source ship list #1922

28 of 28 tasks complete
@danfuzz

This comment has been minimized.

Show comment
Hide comment
@danfuzz

danfuzz May 8, 2014

Contributor

Is there a reason that a document pane isn't a "top-level" CSS context, like an HTML frame?

Apologies in advance for my likely naïveté.

Contributor

danfuzz commented May 8, 2014

Is there a reason that a document pane isn't a "top-level" CSS context, like an HTML frame?

Apologies in advance for my likely naïveté.

@danfuzz

This comment has been minimized.

Show comment
Hide comment
@danfuzz

danfuzz Sep 15, 2014

Contributor

Curious if there's anything in particular blocking this issue. Not that you know me from Adam, but this issue is the only one stopping me from using Atom for real work.

Contributor

danfuzz commented Sep 15, 2014

Curious if there's anything in particular blocking this issue. Not that you know me from Adam, but this issue is the only one stopping me from using Atom for real work.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Sep 15, 2014

Contributor

@danfuzz We're seriously considering using the shadow DOM to avoid problems like this, but we're still laying the groundwork to switch to it. It's definitely something we're aware of.

Contributor

nathansobo commented Sep 15, 2014

@danfuzz We're seriously considering using the shadow DOM to avoid problems like this, but we're still laying the groundwork to switch to it. It's definitely something we're aware of.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Sep 18, 2014

Member

This came up again today with https://github.com/atom/atom/blob/ba49f5d0b8f9e0b4bafd19df9eddf8e005a427fd/static/notification.less conflicting with https://github.com/atom/language-objective-c/blob/4529ff27beeb6d35a2724299f20ec9a6bf8c57b5/grammars/objective-c.cson#L225-L230

resulting in:


(courtesy of @notwaldorf)

I removed the notification.less stylesheet since it was obsolete but it would still be great to fix this once and for all.

Member

kevinsawicki commented Sep 18, 2014

This came up again today with https://github.com/atom/atom/blob/ba49f5d0b8f9e0b4bafd19df9eddf8e005a427fd/static/notification.less conflicting with https://github.com/atom/language-objective-c/blob/4529ff27beeb6d35a2724299f20ec9a6bf8c57b5/grammars/objective-c.cson#L225-L230

resulting in:


(courtesy of @notwaldorf)

I removed the notification.less stylesheet since it was obsolete but it would still be great to fix this once and for all.

@nathansobo nathansobo closed this in #3943 Nov 5, 2014

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Nov 5, 2014

Contributor

This actually won't really be closed until we default the shadow DOM to enabled. I linked the PR to this issue before we decided to make a feature flag.

Contributor

nathansobo commented Nov 5, 2014

This actually won't really be closed until we default the shadow DOM to enabled. I linked the PR to this issue before we decided to make a feature flag.

@benogle

This comment has been minimized.

Show comment
Hide comment
@benogle

benogle Jan 19, 2015

Contributor

@nathansobo can we close this now?

Contributor

benogle commented Jan 19, 2015

@nathansobo can we close this now?

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Jan 19, 2015

Contributor

Yeah. It's still possible to turn the shadow DOM off but it's not recommended.

Contributor

nathansobo commented Jan 19, 2015

Yeah. It's still possible to turn the shadow DOM off but it's not recommended.

@nathansobo nathansobo closed this Jan 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment