New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.33.0-beta1] Typing "#" is currently broken in the beta #18376

Closed
mmstick opened this Issue Nov 1, 2018 · 10 comments

Comments

Projects
None yet
6 participants
@mmstick

mmstick commented Nov 1, 2018

In 1.32.0, Typing # within double quotes would just enter #. Now, it does more than that, and for some reason inserts #{} with the cursor moved between the {} instead. This is mildly infuriating when trying to write out an expression like so:

eprintln!("{:#?}", value);

peek 2018-10-31 21-32

@Aerijo

This comment has been minimized.

Contributor

Aerijo commented Nov 1, 2018

@mmstick I tried it just now in a new blank file, but could not reproduce. Please fill out the issue template that is given when creating an issue, so we know what steps to follow.

Having said that, it seems to reproduce when switching the grammar to C. It's also only on Tree-sitter grammars

/cc @maxbrunsfeld

@Aerijo

This comment has been minimized.

Contributor

Aerijo commented Nov 1, 2018

@mmstick For now, you can work around it by toggling Settings -> Core -> Use Tree Sitter Parsers, or alternatively disable the bracket-matcher package.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Nov 1, 2018

Wow, that's awful. It looks like a features associated with Ruby, that's happening all the time for some reason.

@Aerijo

This comment has been minimized.

Contributor

Aerijo commented Nov 1, 2018

@maxbrunsfeld See this. With tree-sitter enabled, it will pretty much always treat the string as interpolated, and so add the {}.

Maybe languages with interpolated strings can have that added to the nodes / CSS scopes?

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Nov 1, 2018

Oh yeah, of course; the bracket-matcher has all of this language-specific stuff baked into it. I want to make bracket-matching work completely differently now that we have Tree-sitter, but haven't had the chance yet. I'll just fix this by keeping with the "bunch of hard-coded languages" approach in bracket-matcher.

@mmstick

This comment has been minimized.

mmstick commented Nov 1, 2018

@Aerijo It's happening for me with Rust files.

@devsware

This comment has been minimized.

devsware commented Nov 8, 2018

I can reproduce that in ver. 1.32.1 too, with Javascript files (for example writing a css selector like #my-element produces #{my-element}).

Disabling bracket-matcher plugin alone doesn't seem to do the trick, while disabling the Tree Sitter Parsers restores the desired behavior.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Nov 8, 2018

This fix will go out in 132.2 and 1.33.0-beta2.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Nov 9, 2018

1.32.2 and 1.33.0-beta2 are out.

@loesberg

This comment has been minimized.

loesberg commented Nov 9, 2018

Just installed the update, and this issue is fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment