Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File -> Open Folder displays Open File dialog #18971

Closed
hkp-wcd opened this Issue Mar 12, 2019 · 9 comments

Comments

Projects
None yet
9 participants
@hkp-wcd
Copy link

hkp-wcd commented Mar 12, 2019

Prerequisites

Description

File -> Open Folder no longer shows the dialog for Open Folder instead displays the Open File dialog.
The Open Folder dialog is still accessible via Shortcut Ctrl+Shift+O

Steps to Reproduce

  1. Click File
  2. Click Open Folder

Expected behavior: Opens Select Folder window

Actual behavior: Opens Select File window

Reproduces how often: 100%

Versions

Atom : 1.35.0
Electron: 2.0.18
Chrome : 61.0.3163.100
Node : 8.9.3

OS: Windows 10

@bindlock

This comment has been minimized.

Copy link

bindlock commented Mar 12, 2019

The same behavior. Kubuntu 18.04

@RvZ

This comment has been minimized.

Copy link

RvZ commented Mar 12, 2019

The same behavior on windows 10

@remyjacobs

This comment was marked as spam.

Copy link

remyjacobs commented Mar 12, 2019

Same here as well, on Win10

@bloopletech

This comment has been minimized.

Copy link

bloopletech commented Mar 12, 2019

Looks like this change #17529 introduced the bug via a copy+paste error, and the big was fixed in #18855, but that branch/commit didn't make it into 1.35.0: https://github.com/atom/atom/blob/v1.35.0/src/main-process/atom-application.js#L388

@rsese rsese added the triaged label Mar 12, 2019

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Mar 12, 2019

Thanks for the report all 👍 Reproduced on 1.35.0 with Ubuntu 18.04.

@rsese rsese added the regression label Mar 12, 2019

@jasonrudolph jasonrudolph self-assigned this Mar 12, 2019

@jasonrudolph

This comment has been minimized.

Copy link
Member

jasonrudolph commented Mar 12, 2019

It looks like this bug snuck into both Atom 1.35.0 and Atom 1.36.0-beta0. 🙈 We're working on getting the fix from #18855 backported for inclusion in Atom 1.35.1 and Atom 1.36.0-beta1.

Thanks again for reporting this. 🙇

@Ellip-commerce

This comment was marked as spam.

Copy link

Ellip-commerce commented Mar 13, 2019

When do you give a better version? I also have this problem

@jasonrudolph

This comment has been minimized.

Copy link
Member

jasonrudolph commented Mar 13, 2019

Atom 1.35.1 is now available with this fix. If you're on the beta channel, Atom 1.36.0-beta1 is now available with this fix as well.

If you continue to experience this issue after upgrading to the latest Atom version, please let us know.

@gabriel-tessier

This comment has been minimized.

Copy link

gabriel-tessier commented Mar 14, 2019

I still have the problem after the upgrade to 1.35.1, the window pop-up is now correct "Open Folder" but after selecting the folder and click on OK nothing happen.

Upgrading via Kubuntu update.

Fixed! after close atom.... and open atom install vcode then open atom try to open folder and close atom.... Now it's work correctly!!!

Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.