Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Prompts for restart when certain core settings aren't default #19323
If one of the core setting that are configured to prompt for a restart are changed from their default value then Atom will prompt for a restart every time it starts up.
Steps to Reproduce
Expected behavior: [What you expect to happen]
Actual behavior: [What actually happens]
Reproduces how often: [What percentage of the time does it reproduce?]
OS: Windows 10 x64
If you're on Windows, once this AppVeyor build goes green (modulo any flakiness), you should be able to pull down an artifact from the dev channel. I couldn't reproduce your issues once that fix was in, and I couldn't even start Atom before #19321 was merged, so I'm curious where the latest fixes leave things for you.
I added some logging to the
Edit: Confirmed that if I change the setting to
Updated the description: This actually is only tangentially related to the file system watcher changes.
It turns out that any of these settings will always prompt for a restart if they are changed from the default value.
We likely need to put this event subscription to somewhere in the startup process after user settings have first been applied.
I think this was introduced in #19246. On Windows, we're no longer