Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting font size to 14 doesn't persist and has unexpected behaviour on `window:reset-font-size` #19521

Closed
Songworks opened this issue Jun 13, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@Songworks
Copy link

commented Jun 13, 2019

Prerequisites

Description

I got the following behaviour starting with Atom 1.38.x.
When I set the font size as 14 (which is the default), the setting doesn't persist beyond restart and when executing window:reset-font-size it sets font size to whatever was previously set by first executed command of either window:increase-font-size or window:decrease-font-size.

Steps to Reproduce

If I set the font size as 14 and restart Atom, font size appears as empty (renders placeholder: Default: 14), I then get the following two different behaviour depending on the steps:

  • Increase font-size with window:increase-font-size
  • Reset font-size with window:reset-font-size
  • Result: Font size is now set to 15

Another result:

  • Decrease font-size with window:decrease-font-size
  • Reset font-size with window:reset-font-size
  • Result: Font size is now set to 13

Additional if it Atom already knows a previous font size (like the 13 or 15), window:reset-font-size will keep using this font size, even if the user enters another font size manually, fe. 16.

Expected behavior: Should be able to manually enter font size 14 and window:reset-font-size should reset to whatever was the last manually entered font size

Actual behavior: Manually setting font size 14 doesn't persist and window:reset-font-size sets font size to whatever was previously known or last used by/in Atom

Reproduces how often: 100%

Versions

Atom : 1.38.1
Electron: 2.0.18
Chrome : 61.0.3163.100
Node : 8.9.3

apm 2.1.7
npm 6.2.0
node 8.9.3 x64
atom 1.38.1
python 2.7.12
git 2.21.0

OS: Linux Mint 17.3 (Ubuntu 16.04 based)

Additional Information

Perhaps related to this pull request?
#19192

Cheers!

@Songworks

This comment has been minimized.

Copy link
Author

commented Jun 18, 2019

@nathansobo Issue is resolved with 1.38.2 for me. Thanks for the fast work!

@dirtyarteaga

This comment was marked as spam.

Copy link

commented Jun 25, 2019

👷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.